You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/02 22:16:19 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
alexeykudinkin opened a new pull request #3909:
URL: https://github.com/apache/hudi/pull/3909
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
This PR fixes RAT Maven plugin configuration to make sure that running `mvn clean package install` isn't having issues with RAT plugin complaining about transient files lacking Apache license attribution
Example failure when running `mvn clean package -DskipTests -Dspark3 -Dscala.usejavacp=true`
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project hudi-utilities-bundle_2.12: Too many files with unapproved license: 4 See RAT report in: /Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/rat.txt -> [Help 1]
```
Files RAT is complaining about (lacking the license header)
```
Files with unapproved licenses:
/Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/rat.txt
/Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
/Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
/Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/maven-archiver/pom.properties
```
## Brief change log
- Fixing RAT plugin config, replicating one from root `pom.xml` (stripping license configuration part)
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
This change verified with running successfully `mvn clean package -DskipTests -Dspark3 -Dscala.usejavacp=true`
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958273836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#discussion_r741591461
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -36,6 +36,28 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <configuration>
+ <excludeSubProjects>false</excludeSubProjects>
+ <numUnapprovedLicenses>0</numUnapprovedLicenses>
Review comment:
makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3909:
URL: https://github.com/apache/hudi/pull/3909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958273836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3078",
"triggerID" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3078)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958273836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3078",
"triggerID" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3078)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3909:
URL: https://github.com/apache/hudi/pull/3909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#discussion_r741591461
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -36,6 +36,28 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <configuration>
+ <excludeSubProjects>false</excludeSubProjects>
+ <numUnapprovedLicenses>0</numUnapprovedLicenses>
Review comment:
makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958616482
thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#discussion_r741503390
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -36,6 +36,28 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <configuration>
+ <excludeSubProjects>false</excludeSubProjects>
+ <numUnapprovedLicenses>0</numUnapprovedLicenses>
Review comment:
<licenseFamilies> as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958616482
thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3909:
URL: https://github.com/apache/hudi/pull/3909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958616482
thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a change in pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on a change in pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#discussion_r741506956
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -36,6 +36,28 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <configuration>
+ <excludeSubProjects>false</excludeSubProjects>
+ <numUnapprovedLicenses>0</numUnapprovedLicenses>
Review comment:
My understanding is that hudi-utilities-bundle is an anchor project to tie all of Hudi into a single fat jar. As such i'm expecting that individual projects continue to enforce individual license configs, and in this pom we're only looking to exclude irrelevant transient directories/files. Hence didn't copy the licensing part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#discussion_r741591461
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -36,6 +36,28 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <configuration>
+ <excludeSubProjects>false</excludeSubProjects>
+ <numUnapprovedLicenses>0</numUnapprovedLicenses>
Review comment:
makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#discussion_r741503036
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -36,6 +36,28 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <configuration>
+ <excludeSubProjects>false</excludeSubProjects>
+ <numUnapprovedLicenses>0</numUnapprovedLicenses>
Review comment:
Any reason why you haven't copied as is from root pom?
```
<licenses>
<!-- Enforce this license:
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
<licenseFamilyCategory>AL2 </licenseFamilyCategory>
<licenseFamilyName>Apache License 2.0</licenseFamilyName>
<notes />
<patterns>
<pattern>Licensed to the Apache Software Foundation (ASF) under one</pattern>
</patterns>
</license>
</licenses>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958616482
thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3909:
URL: https://github.com/apache/hudi/pull/3909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#issuecomment-958273836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3078",
"triggerID" : "3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e1bd1c64cefc36544f52dc7cf577da3f7f5ac28 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3078)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3909: Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3909:
URL: https://github.com/apache/hudi/pull/3909#discussion_r741591461
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -36,6 +36,28 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <configuration>
+ <excludeSubProjects>false</excludeSubProjects>
+ <numUnapprovedLicenses>0</numUnapprovedLicenses>
Review comment:
makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org