You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tengpeng <gi...@git.apache.org> on 2018/06/10 23:38:15 UTC
[GitHub] spark pull request #21524: [SPARK-24212][ML][doc] Add the example and user g...
GitHub user tengpeng opened a pull request:
https://github.com/apache/spark/pull/21524
[SPARK-24212][ML][doc] Add the example and user guide for ML PrefixSpan
## What changes were proposed in this pull request?
There are no example and user guide for ML PrefixSpan (not MLlib PrefixSpan).
This PR adds an example and a user guide.
## How was this patch tested?
Generated the local web page. See the screenshot.
<img width="812" alt="screenshot 2018-06-10 18 27 39" src="https://user-images.githubusercontent.com/2724786/41207516-3d5c137e-6cdd-11e8-8e8f-f713231cc4fd.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tengpeng/spark Spark-24212
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21524
----
commit 333f97e48ffab3354bf2627959c40ac7a394a979
Author: Teng Peng <jo...@...>
Date: 2018-06-10T23:31:56Z
Add the example and user guide for ML PrefixSpan
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21524
@tengpeng there's no deadline, but 2.4 is being released imminently and doc/example improvements can go in this week, probably. If it's going to be a while before you can update, we generally close pull requests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by tengpeng <gi...@git.apache.org>.
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/21524
Let's close it for now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21524
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21524
@tengpeng would you like to update this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21524: [SPARK-24212][ML][doc] Add the example and user g...
Posted by tengpeng <gi...@git.apache.org>.
Github user tengpeng closed the pull request at:
https://github.com/apache/spark/pull/21524
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21524
OK I guess this is just copied from the .mllib example and docs? I guess that's OK as this was done for other docs/examples. There's a Python API for this one too, it seems; how about a quick Python example to round it out?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by tengpeng <gi...@git.apache.org>.
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/21524
Right, the doc is mostly copied with minor modifications. Let me update my
PR for the Python API this weekend.
On Fri, Sep 7, 2018 at 12:28 PM Sean Owen <no...@github.com> wrote:
> CC @tengpeng <https://github.com/tengpeng>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/21524#issuecomment-419509986>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ACmTsjgw1xDc_lTmAV5NpUTnMNorYqoBks5uYqy0gaJpZM4Uh6w5>
> .
>
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21524
Jenkins OK to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by tengpeng <gi...@git.apache.org>.
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/21524
Yes, but may not be recently. Is there a "deadline" (e.g. branch cut)
coming?
On Tue, Sep 18, 2018 at 4:23 PM Sean Owen <no...@github.com> wrote:
> @tengpeng <https://github.com/tengpeng> would you like to update this?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/21524#issuecomment-422560148>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ACmTsqnS6MUDidJEDMJYrNSmi5efFL_rks5ucWRUgaJpZM4Uh6w5>
> .
>
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21524
CC @tengpeng
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21524
Ping @tengpeng to update or close
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21524
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21524
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21524: [SPARK-24212][ML][doc] Add the example and user guide fo...
Posted by tengpeng <gi...@git.apache.org>.
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/21524
Gentle ping @jkbradley @WeichenXu123 @mengxr Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org