[GitHub] [druid] techdocsmith commented on a change in pull request #11333: Eliminate ambiguities of KB/MB/GB in the doc

[GitBox <gi...@apache.org>]

techdocsmith commented on a change in pull request #11333:
URL: https://github.com/apache/druid/pull/11333#discussion_r647024996



##########
File path: core/src/main/java/org/apache/druid/data/input/MaxSizeSplitHintSpec.java
##########
@@ -53,7 +53,7 @@
    * - 'jute.maxbuffer' in ZooKeeper. This system property controls the max size of ZNode. As its default is 500KB,
    *   task allocation can fail if the serialized ingestion spec is larger than this limit.
    * - 'max_allowed_packet' in MySQL. This is the max size of a communication packet sent to a MySQL server.
-   *   The default is either 64MB or 4MB depending on MySQL version. Updating metadata store can fail if the serialized
+   *   The default is either <a href="https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_max_allowed_packet">64MiB</a> or 4MiB depending on MySQL version. Updating metadata store can fail if the serialized

Review comment:
       nit: why not use markdown anchor syntax.

##########
File path: website/.spelling
##########
@@ -1210,18 +1210,17 @@ taskId
 taskid
 un
  - ../docs/operations/basic-cluster-tuning.md
-100MB
-128MB
+100MiB

Review comment:
       too bad spelling system doesn't have a better way of handling all these like `KiB, GiB` :/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org