You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/03 10:10:31 UTC
[GitHub] [cloudstack] rp- opened a new pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
rp- opened a new pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661
With diskful set to true, linstor will fail if it cannot create local
storage for the resource. Which in turn will make it impossible to have a
setup with just compute nodes on cloudstack.
### Description
This is a small bugfix that will enable to have cloudstack-agents without storage to work with Linstor volume plugin.
Before the plugin always tried to create a diskful assignment on nodes on connect, but if the node doesn't have
linstor storage, this would fail and node automatically fallback to a diskless resource.
This was intentionally done to improve performance, as having a local disk makes write operations faster,
but there are other ways to configure diskful nodes within linstor(auto diskful, manual toggle disk).
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [x] BLOCKER (for compute node setups, with linstor)
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
Local cluster setup, but the change is only within the linstor plugin, so should not have any impact on other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959782905
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959778708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959778998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959778998
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959779065
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959779065
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rp- commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-958981588
@rhtyd It would be great if this could be included in the next RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rp- commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-958981588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959778998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959779065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959778708
Changes are strictly in the Linstor plugin which we don't have any means to test. We can merge this based on author/maintainers testing and smoketests from Travis and packaging pass. No need to run actual smoketests.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959811713
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rp- commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-958981588
@rhtyd It would be great if this could be included in the next RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959778708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #5661: linstor-volume-plugin: Only create diskless assignments on nodes
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #5661:
URL: https://github.com/apache/cloudstack/pull/5661#issuecomment-959779065
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org