[GitHub] [incubator-druid] glasser commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex

[GitBox <gi...@apache.org>]

glasser commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex
URL: https://github.com/apache/incubator-druid/pull/7171#discussion_r262197495
 
 

 ##########
 File path: integration-tests/src/test/resources/indexer/wikipedia_reindex_queries.json
 ##########
 @@ -0,0 +1,66 @@
+[
 
 Review comment:
   The differences are:
   
   - maxTime in the first query is different (because the second ingest pulls a subset of time)
   - not asking for the now-gone `count` metric in the second query (is that what you mean by `rows`?)
   
   Are you proposing just not doing queries at all after the reingest? It seems reasonable to validate that some data ended up in the new datasource.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org