You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 22:31:43 UTC

Review Request 66994: Added a test for exhaustively allocating declined resources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66994/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and Vinod Kone.


Repository: mesos


Description
-------

This test ensures that when `exhaustively_allocate_declined_resources`
is turned on, the allocator can exhaustively allocate resources
from a declined agent before reallocating resources from that agent
back to the decliner.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4 


Diff: https://reviews.apache.org/r/66994/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Re: Review Request 66994: Added a test for exhaustively allocating declined resources.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66994/#review202614
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66981, 66982, 66983, 66984, 66990, 66994]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 7, 2018, 10:31 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66994/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 10:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that when `exhaustively_allocate_declined_resources`
> is turned on, the allocator can exhaustively allocate resources
> from a declined agent before reallocating resources from that agent
> back to the decliner.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4 
> 
> 
> Diff: https://reviews.apache.org/r/66994/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>