You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Edzard Hoefig (JIRA)" <ji...@apache.org> on 2008/07/17 20:53:33 UTC
[jira] Created: (SCXML-77) is not working properly with
only a single "name" attribute
<param> is not working properly with only a single "name" attribute
-------------------------------------------------------------------
Key: SCXML-77
URL: https://issues.apache.org/jira/browse/SCXML-77
Project: Commons SCXML
Issue Type: Bug
Affects Versions: 0.8
Reporter: Edzard Hoefig
Priority: Minor
Attachments: commons-scxml_param-name-location_patch_ehoefig
WD-scxml-20080516, section 4.3.1 says:
If the "expr" attribute is missing, the "name" attribute will be taken as a data model location expression (see 8.2 Location Expressions) and the value at that location will be passed to the invoked component. If the "name" attribute does not refer to a location in the data model, an error error.illegalalloc will be generated.
SCXMLSemanticsImpl.java seems to not handle this properly, as it is ignoring the case where a single "name" attribute is used (line 793).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-77) is not working properly with
only a single "name" attribute
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615090#action_12615090 ]
Rahul Akolkar commented on SCXML-77:
------------------------------------
Thanks, I can confirm that your ICLA has been recorded by the ASF Secretary. I'll get back to this issue in the coming week.
> <param> is not working properly with only a single "name" attribute
> -------------------------------------------------------------------
>
> Key: SCXML-77
> URL: https://issues.apache.org/jira/browse/SCXML-77
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Edzard Hoefig
> Priority: Minor
> Fix For: 0.9
>
> Attachments: commons-scxml_param-name-location_patch_ehoefig
>
>
> WD-scxml-20080516, section 4.3.1 says:
> If the "expr" attribute is missing, the "name" attribute will be taken as a data model location expression (see 8.2 Location Expressions) and the value at that location will be passed to the invoked component. If the "name" attribute does not refer to a location in the data model, an error error.illegalalloc will be generated.
> SCXMLSemanticsImpl.java seems to not handle this properly, as it is ignoring the case where a single "name" attribute is used (line 793).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-77) is not working properly with
only a single "name" attribute
Posted by "Edzard Hoefig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614670#action_12614670 ]
Edzard Hoefig commented on SCXML-77:
------------------------------------
That's fine with us, I just sent the signed ICLA per fax.
> <param> is not working properly with only a single "name" attribute
> -------------------------------------------------------------------
>
> Key: SCXML-77
> URL: https://issues.apache.org/jira/browse/SCXML-77
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Edzard Hoefig
> Priority: Minor
> Fix For: 0.9
>
> Attachments: commons-scxml_param-name-location_patch_ehoefig
>
>
> WD-scxml-20080516, section 4.3.1 says:
> If the "expr" attribute is missing, the "name" attribute will be taken as a data model location expression (see 8.2 Location Expressions) and the value at that location will be passed to the invoked component. If the "name" attribute does not refer to a location in the data model, an error error.illegalalloc will be generated.
> SCXMLSemanticsImpl.java seems to not handle this properly, as it is ignoring the case where a single "name" attribute is used (line 793).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-77) is not working properly with
only a single "name" attribute
Posted by "Edzard Hoefig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edzard Hoefig updated SCXML-77:
-------------------------------
Attachment: commons-scxml_param-name-location_patch_ehoefig
This is a patch that should get rid of the issue.
> <param> is not working properly with only a single "name" attribute
> -------------------------------------------------------------------
>
> Key: SCXML-77
> URL: https://issues.apache.org/jira/browse/SCXML-77
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Edzard Hoefig
> Priority: Minor
> Attachments: commons-scxml_param-name-location_patch_ehoefig
>
>
> WD-scxml-20080516, section 4.3.1 says:
> If the "expr" attribute is missing, the "name" attribute will be taken as a data model location expression (see 8.2 Location Expressions) and the value at that location will be passed to the invoked component. If the "name" attribute does not refer to a location in the data model, an error error.illegalalloc will be generated.
> SCXMLSemanticsImpl.java seems to not handle this properly, as it is ignoring the case where a single "name" attribute is used (line 793).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-77) is not working properly with
only a single "name" attribute
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar updated SCXML-77:
-------------------------------
Fix Version/s: 0.9
Thanks for the patch, that helps :-) I'm traveling and will look at this next week. Setting fix version to next release (v0.9).
I'd suggest you also fill out an Individual Contributor License Agreement (ICLA). That is here (the fax number is on the form itself, you can mail it in too if you want):
http://www.apache.org/licenses/icla.txt
Its a one-time thing (so you won't need to do it for any more patches you submit across all projects at the ASF), and is needed for non-trivial contributions, for provenance and pedigree reasons. Let us know once its sent in (so we can track to see when it gets recorded). Let us know if you have questions about this.
> <param> is not working properly with only a single "name" attribute
> -------------------------------------------------------------------
>
> Key: SCXML-77
> URL: https://issues.apache.org/jira/browse/SCXML-77
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Edzard Hoefig
> Priority: Minor
> Fix For: 0.9
>
> Attachments: commons-scxml_param-name-location_patch_ehoefig
>
>
> WD-scxml-20080516, section 4.3.1 says:
> If the "expr" attribute is missing, the "name" attribute will be taken as a data model location expression (see 8.2 Location Expressions) and the value at that location will be passed to the invoked component. If the "name" attribute does not refer to a location in the data model, an error error.illegalalloc will be generated.
> SCXMLSemanticsImpl.java seems to not handle this properly, as it is ignoring the case where a single "name" attribute is used (line 793).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SCXML-77) is not working properly with
only a single "name" attribute
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar resolved SCXML-77.
--------------------------------
Resolution: Fixed
Thanks for the patch, it has been applied in r680521:
http://svn.apache.org/viewvc?view=rev&revision=680521
I changed the tests to be in the invoke package (could have gone either way) and added the "dummy" invoker as a static nested class (I try to avoid more than one Java source file per test).
Please try the latest code from SVN to verify the fix. Thanks again.
> <param> is not working properly with only a single "name" attribute
> -------------------------------------------------------------------
>
> Key: SCXML-77
> URL: https://issues.apache.org/jira/browse/SCXML-77
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Edzard Hoefig
> Priority: Minor
> Fix For: 0.9
>
> Attachments: commons-scxml_param-name-location_patch_ehoefig
>
>
> WD-scxml-20080516, section 4.3.1 says:
> If the "expr" attribute is missing, the "name" attribute will be taken as a data model location expression (see 8.2 Location Expressions) and the value at that location will be passed to the invoked component. If the "name" attribute does not refer to a location in the data model, an error error.illegalalloc will be generated.
> SCXMLSemanticsImpl.java seems to not handle this properly, as it is ignoring the case where a single "name" attribute is used (line 793).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SCXML-77) is not working properly with only
a single "name" attribute
Posted by "Edzard Hoefig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edzard Hoefig closed SCXML-77.
------------------------------
works fine for me
> <param> is not working properly with only a single "name" attribute
> -------------------------------------------------------------------
>
> Key: SCXML-77
> URL: https://issues.apache.org/jira/browse/SCXML-77
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Edzard Hoefig
> Priority: Minor
> Fix For: 0.9
>
> Attachments: commons-scxml_param-name-location_patch_ehoefig
>
>
> WD-scxml-20080516, section 4.3.1 says:
> If the "expr" attribute is missing, the "name" attribute will be taken as a data model location expression (see 8.2 Location Expressions) and the value at that location will be passed to the invoked component. If the "name" attribute does not refer to a location in the data model, an error error.illegalalloc will be generated.
> SCXMLSemanticsImpl.java seems to not handle this properly, as it is ignoring the case where a single "name" attribute is used (line 793).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.