You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/04 19:27:13 UTC
[GitHub] [airflow] potiuk opened a new pull request, #31704: Limit parallelism to 1 for mssql tests on self-hosted runners
potiuk opened a new pull request, #31704:
URL: https://github.com/apache/airflow/pull/31704
In case MSSQL tests are run on public runners, they often produce flake tests due to some race conditions that are difficult to fix.
The issue for the flake tests is captured in #31575
Likely the race conditions are resulting from attempt to run only one scheduler loop and they are not impacting production. Also the MSSQL tests are rarely run on public runners - only for PRS that have "full-tests-needed" set, so slowing down the tests in those cases is better than having flakes.
This PR forces parallelism = 1 for MSSQL tests in case they are run on public runners in an attempt to get rid of the flake tests.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #31704: Limit parallelism to 1 for mssql tests on self-hosted runners
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31704:
URL: https://github.com/apache/airflow/pull/31704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #31704: Limit parallelism to 1 for mssql tests on self-hosted runners
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #31704:
URL: https://github.com/apache/airflow/pull/31704#issuecomment-1577057964
Thanks for this. I guess I was barking up the wrong tree. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org