[GitHub] [accumulo] dlmarion commented on a diff in pull request #3161: Rename GarbageCollectionLogger, use it to pause scans until memory usage is lower

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #3161:
URL: https://github.com/apache/accumulo/pull/3161#discussion_r1072738565


##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -348,6 +348,16 @@ public enum Property {
           + "indefinitely. Default is 0 to block indefinitely. Only valid when tserver available "
           + "threshold is set greater than 0. Added with version 1.10",
       "1.10.0"),
+  MANAGER_LOW_MEM_DETECTOR_ACTIVE("manager.low.mem.detector.active", "false", PropertyType.BOOLEAN,
+      "By default the LowMemoryDetector is passive, it just logs that memory is low. Setting this to true"
+          + " may change the behavior of server components that check the LowMemoryDetector state",
+      "3.0.0"),
+  MANAGER_LOW_MEM_DETECTOR_INTERVAL("manager.low.mem.detector.interval", "5s",
+      PropertyType.TIMEDURATION, "The number of milliseconds between low memory checks", "3.0.0"),
+  MANAGER_LOW_MEM_DETECTOR_THRESHOLD("manager.low.mem.detector.treshold", "0.05",
+      PropertyType.FRACTION,
+      "The LowMemoryDetector will report when free memory drops below this percentage of total memory",

Review Comment:
   User may want to have different free memory thresholds for different components (manager vs tserver for example). Only the scan code and scan iterators do anything with this information, but that could change in a future PR. I do think it's verbose, but provides the most flexibility moving forward.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org