You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Filip Maj (Created) (JIRA)" <ji...@apache.org> on 2012/04/18 02:13:13 UTC
[jira] [Created] (CB-532) Update JS module IDs and remove
extraneous directory under lib//plugin
Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
-------------------------------------------------------------------------------------------
Key: CB-532
URL: https://issues.apache.org/jira/browse/CB-532
Project: Apache Callback
Issue Type: Task
Components: CordovaJS
Reporter: Filip Maj
Assignee: Filip Maj
Priority: Minor
Fix For: 1.8.0
Unnecessary to have that extra dir - as long as the module IDs map to the module string in an obvious manner, that's all we want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-532) Update JS module IDs and remove
extraneous directory under lib//plugin
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-532.
--------------------------
Resolution: Won't Fix
Fix Version/s: (was: 1.8.0)
This issue is not pertinent. It sucks having the extra "platform" dir at the end of lib/platform/plugins/platform, but it makes sense when it comes to module IDs.
> Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
> -------------------------------------------------------------------------------------------
>
> Key: CB-532
> URL: https://issues.apache.org/jira/browse/CB-532
> Project: Apache Callback
> Issue Type: Task
> Components: CordovaJS
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
>
> Unnecessary to have that extra dir - as long as the module IDs map to the module string in an obvious manner, that's all we want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-532) Update JS module IDs and remove
extraneous directory under lib//plugin
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256665#comment-13256665 ]
Filip Maj commented on CB-532:
------------------------------
Right.. sigh. The way I see it is it's either too wordy, or not clear enough in terms of module ids to path mapping.
> Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
> -------------------------------------------------------------------------------------------
>
> Key: CB-532
> URL: https://issues.apache.org/jira/browse/CB-532
> Project: Apache Callback
> Issue Type: Task
> Components: CordovaJS
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Fix For: 1.8.0
>
>
> Unnecessary to have that extra dir - as long as the module IDs map to the module string in an obvious manner, that's all we want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-532) Update JS module IDs and remove
extraneous directory under lib//plugin
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256157#comment-13256157 ]
Patrick Mueller commented on CB-532:
------------------------------------
Just to be a little more clear, the intent of the great module file/directory refactoring a point release or two ago, was to make the path/file names of the modules line up more directly with the eventual module ids that would be used for the modules.
I pointed out in the ml that the "structure" of the files within a plugin - in terms of directory names / module paths - may change again later once we have a 3rd party plugin story. And it wouldn't surprise me if the platform names then re-appeared back in the module ids, for instance.
Depending on how close we are to having a 3rd part plugin story, it could be kinda pointless to make this kind of change.
> Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
> -------------------------------------------------------------------------------------------
>
> Key: CB-532
> URL: https://issues.apache.org/jira/browse/CB-532
> Project: Apache Callback
> Issue Type: Task
> Components: CordovaJS
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Fix For: 1.8.0
>
>
> Unnecessary to have that extra dir - as long as the module IDs map to the module string in an obvious manner, that's all we want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-532) Update JS module IDs and remove
extraneous directory under lib//plugin
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256699#comment-13256699 ]
Patrick Mueller commented on CB-532:
------------------------------------
If by "wordy" you mean, in our existing modules, things like this: [1]
{noformat}
polling = require('cordova/plugin/android/polling')
{noformat}
which happens to be called from the module with module id "cordva/plugin/android/callback".
There's a fix for that. [2]
The patch for [2] would allow you to replace the line above with:
{noformat}
polling = require('./polling')
{noformat}
I believe the only feedback received from this bug (musta been on the ml) was "we don't need that yet". Do we need it yet? :-)
I'm sure [2] will need a bit of re-work, it's a bit old, but I'm happy to land it, and then add the additional CommonJS tests into the mix as well.
[1] https://github.com/apache/incubator-cordova-js/blob/master/lib/android/plugin/android/callback.js#L4
[2] https://issues.apache.org/jira/browse/CB-272
> Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
> -------------------------------------------------------------------------------------------
>
> Key: CB-532
> URL: https://issues.apache.org/jira/browse/CB-532
> Project: Apache Callback
> Issue Type: Task
> Components: CordovaJS
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Fix For: 1.8.0
>
>
> Unnecessary to have that extra dir - as long as the module IDs map to the module string in an obvious manner, that's all we want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira