[GitHub] [activemq-artemis] davidlanouette commented on a diff in pull request #4362: ARTEMIS-4160 Handle hostnames with invalid char sequences.

["davidlanouette (via GitHub)" <gi...@apache.org>]

davidlanouette commented on code in PR #4362:
URL: https://github.com/apache/activemq-artemis/pull/4362#discussion_r1103032101


##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/jolokia-access.xml:
##########
@@ -23,7 +23,7 @@ under the License.
 <restrict>
 
     <cors>
-        <!-- Allow cross origin access from ${http.host} ... -->
+        <!-- Allow cross origin access from ${http.host-for-comment} ... -->

Review Comment:
   That is a much simpler solution if nobody is tied to having the hostname in that comment.
   
   I'll adjust (remove the other changes, and update this comment, then update the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org