You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/05/01 19:52:35 UTC

[GitHub] [systemml] mboehm7 commented on pull request #754: [SYSTEMML-2078] Add support for global variables

mboehm7 commented on pull request #754:
URL: https://github.com/apache/systemml/pull/754#issuecomment-622538191


   Meanwhile, I think not supporting global variables might be better in the long run as it keeps functions (except for explicit reads/writes) side-effect free. Back when discussing this feature, it included two sub problems (1) builtin global constants like NaN, PI, INF, as well as (2) different function scoping rules (with global access). Since (1) has already been introduced (see https://github.com/apache/systemml/commit/4a822a22c88b579e935a1b09051c1fe236e18a4b) and meanwhile we extended the list functionality to pass parameters easier along function call graphs, there is no more a real need for globals. However, I would leave this PR open, in case we come back to it - then this would be an excellent starting point.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org