You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/31 03:49:30 UTC

[GitHub] [spark] huskysun commented on a change in pull request #32701: [SPARK-35562][DOC] Fix docs about Kubernetes

huskysun commented on a change in pull request #32701:
URL: https://github.com/apache/spark/pull/32701#discussion_r642193027



##########
File path: docs/submitting-applications.md
##########
@@ -146,7 +146,7 @@ export HADOOP_CONF_DIR=XXX
 ./bin/spark-submit \
   --class org.apache.spark.examples.SparkPi \
   --master k8s://xx.yy.zz.ww:443 \
-  --deploy-mode cluster \
+  --deploy-mode cluster \  # can be client for client mode

Review comment:
       @yaooqinn @dongjoon-hyun Thanks for the review. Yeah I should've changed L145 as well, from `# Run on a Kubernetes cluster in cluster deploy mode` to `# Run on a Kubernetes cluster`. I was trying to mimicking L117. However I won't do that anymore, because:
   
   > you cannot add # after \ in bash
   
   You're right, `#` can come after `\`. Then, L122 should also be fixed. I will revert this line, and also fix L122. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org