You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/19 16:07:15 UTC

[GitHub] [netbeans] MartinBalin opened a new pull request #2773: VSCode BUILD.MD update for production build.

MartinBalin opened a new pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773


   Correction of how to build for release etc. with prerequisities.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jtulach commented on a change in pull request #2773: VSCode BUILD.MD update for production build.

Posted by GitBox <gi...@apache.org>.
jtulach commented on a change in pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773#discussion_r579605848



##########
File path: java/java.lsp.server/vscode/BUILD.md
##########
@@ -35,10 +42,9 @@ To build the VS Code extension invoke:
 ```bash
 netbeans$ ant build
 netbeans$ cd java/java.lsp.server
-java.lsp.server$ ant build-vscode-ext -D3rdparty.modules=.*nbjavac.*
+java.lsp.server$ ant build-vscode-ext -Dvsix.version=x.y.z
 ```
-
-The `3rdparty.modules` property doesn't have to be set at all.

Review comment:
       Either the `3rdparty.modules` property remains (and then it shall be documented), or it shall be removed. 
   
   If it doesn't work with `m2://` protocol (which it didn't and thus the `nbjavac` example stopped workinig) that should be fixed rather than removing it from documentation completely.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] JaroslavTulach commented on pull request #2773: VSCode BUILD.MD update for production build.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773#issuecomment-784280374


   #2777 makes the `-D3rdparty.modules=.*nbjavac.*` work again. We don't have to promote it as the default option, but I'd suggest to still mention it in the readme. It is the way to make the extension work on JDK8.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] MartinBalin commented on pull request #2773: VSCode BUILD.MD update for production build.

Posted by GitBox <gi...@apache.org>.
MartinBalin commented on pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773#issuecomment-785226425


   Options better documented now in 2nd commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jtulach commented on a change in pull request #2773: VSCode BUILD.MD update for production build.

Posted by GitBox <gi...@apache.org>.
jtulach commented on a change in pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773#discussion_r579605848



##########
File path: java/java.lsp.server/vscode/BUILD.md
##########
@@ -35,10 +42,9 @@ To build the VS Code extension invoke:
 ```bash
 netbeans$ ant build
 netbeans$ cd java/java.lsp.server
-java.lsp.server$ ant build-vscode-ext -D3rdparty.modules=.*nbjavac.*
+java.lsp.server$ ant build-vscode-ext -Dvsix.version=x.y.z
 ```
-
-The `3rdparty.modules` property doesn't have to be set at all.

Review comment:
       Either the `3rdparty.modules` property remain to be documented, or it shall be removed. If it doesn't work with `m2://` protocol (which it didn't), that should be fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] MartinBalin closed pull request #2773: VSCode BUILD.MD update for production build.

Posted by GitBox <gi...@apache.org>.
MartinBalin closed pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jtulach commented on a change in pull request #2773: VSCode BUILD.MD update for production build.

Posted by GitBox <gi...@apache.org>.
jtulach commented on a change in pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773#discussion_r579605848



##########
File path: java/java.lsp.server/vscode/BUILD.md
##########
@@ -35,10 +42,9 @@ To build the VS Code extension invoke:
 ```bash
 netbeans$ ant build
 netbeans$ cd java/java.lsp.server
-java.lsp.server$ ant build-vscode-ext -D3rdparty.modules=.*nbjavac.*
+java.lsp.server$ ant build-vscode-ext -Dvsix.version=x.y.z
 ```
-
-The `3rdparty.modules` property doesn't have to be set at all.

Review comment:
       Either the `3rdparty.modules` property remains (and then it shall be documented), or it shall be removed. 
   
   If it doesn't work with `m2://` protocol (which it didn't and thus the `nbjavac` example stopped workinig) then that should be fixed rather than removing it from documentation completely.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jtulach commented on pull request #2773: VSCode BUILD.MD update for production build.

Posted by GitBox <gi...@apache.org>.
jtulach commented on pull request #2773:
URL: https://github.com/apache/netbeans/pull/2773#issuecomment-785232979


   OK. Just squash the commits into one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists