You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/15 03:37:11 UTC
[GitHub] [commons-configuration] darkma773r opened a new pull request, #188: CONFIGURATION-813: mailapi follow up
darkma773r opened a new pull request, #188:
URL: https://github.com/apache/commons-configuration/pull/188
- simplify mailapi type conversions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] asfgit merged pull request #188: CONFIGURATION-813: mailapi follow up
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #188:
URL: https://github.com/apache/commons-configuration/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #188: CONFIGURATION-813: mailapi follow up
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #188:
URL: https://github.com/apache/commons-configuration/pull/188#discussion_r898344084
##########
src/test/java/org/apache/commons/configuration2/TestDataConfiguration.java:
##########
@@ -358,7 +347,7 @@ public void setUp() throws Exception {
// email address
conf.addProperty("email.string", "ebourg@apache.org");
conf.addProperty("email.string.interpolated", "${email.string}");
- conf.addProperty("email.object", createInternetAddress("ebourg@apache.org"));
+ conf.addProperty("email.object", new InternetAddress("ebourg@apache.org"));
Review Comment:
I don't think we want any PII here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] codecov-commenter commented on pull request #188: CONFIGURATION-813: mailapi follow up
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #188:
URL: https://github.com/apache/commons-configuration/pull/188#issuecomment-1157200350
# [Codecov](https://codecov.io/gh/apache/commons-configuration/pull/188?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#188](https://codecov.io/gh/apache/commons-configuration/pull/188?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5c6227) into [master](https://codecov.io/gh/apache/commons-configuration/commit/9a828da194ad82c250b8af6d2c7f7b4fba1d0cbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a828da) will **increase** coverage by `0.04%`.
> The diff coverage is `62.50%`.
```diff
@@ Coverage Diff @@
## master #188 +/- ##
============================================
+ Coverage 89.42% 89.47% +0.04%
Complexity 3604 3604
============================================
Files 183 183
Lines 10005 10000 -5
Branches 1352 1351 -1
============================================
Hits 8947 8947
+ Misses 774 770 -4
+ Partials 284 283 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-configuration/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/commons/configuration2/DataConfiguration.java](https://codecov.io/gh/apache/commons-configuration/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29uZmlndXJhdGlvbjIvRGF0YUNvbmZpZ3VyYXRpb24uamF2YQ==) | `95.86% <ø> (ø)` | |
| [...mons/configuration2/convert/PropertyConverter.java](https://codecov.io/gh/apache/commons-configuration/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29uZmlndXJhdGlvbjIvY29udmVydC9Qcm9wZXJ0eUNvbnZlcnRlci5qYXZh) | `75.41% <62.50%> (+1.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-configuration/pull/188?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/commons-configuration/pull/188?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a828da...c5c6227](https://codecov.io/gh/apache/commons-configuration/pull/188?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] kinow commented on a diff in pull request #188: CONFIGURATION-813: mailapi follow up
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #188:
URL: https://github.com/apache/commons-configuration/pull/188#discussion_r898350424
##########
src/test/java/org/apache/commons/configuration2/TestDataConfiguration.java:
##########
@@ -358,7 +347,7 @@ public void setUp() throws Exception {
// email address
conf.addProperty("email.string", "ebourg@apache.org");
conf.addProperty("email.string.interpolated", "${email.string}");
- conf.addProperty("email.object", createInternetAddress("ebourg@apache.org"));
+ conf.addProperty("email.object", new InternetAddress("ebourg@apache.org"));
Review Comment:
I think this email was already in the code before this change. There might be more PII in other places, I'm +1 to removing it. Maybe we could do it in a follow up issue if that's easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org