You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2013/02/11 22:23:30 UTC
svn commit: r1444970 -
/subversion/trunk/subversion/bindings/swig/perl/native/t/9wc.t
Author: breser
Date: Mon Feb 11 21:23:30 2013
New Revision: 1444970
URL: http://svn.apache.org/r1444970
Log:
Fix the new SVN::Wc::parse_externals_description3() tests for swig-pl.
* subversion/bindings/swig/perl/native/t/9wc.t:
Convert the tests to using is instead of ok when looking for a value and
isa_ok when looking for a class. Fix the type for the revision and
peg_revision fields since they are pointers. Fix the symbol for accessing
the svn_opt_revision_t enum values. Disable the kind tests on the
svn_opt_revision_t values (accessing this is bugged right now).
Modified:
subversion/trunk/subversion/bindings/swig/perl/native/t/9wc.t
Modified: subversion/trunk/subversion/bindings/swig/perl/native/t/9wc.t
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/swig/perl/native/t/9wc.t?rev=1444970&r1=1444969&r2=1444970&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/swig/perl/native/t/9wc.t (original)
+++ subversion/trunk/subversion/bindings/swig/perl/native/t/9wc.t Mon Feb 11 21:23:30 2013
@@ -21,7 +21,7 @@
#
use strict;
-use Test::More tests => 17;
+use Test::More tests => 13;
# shut up about variables that are only used once.
# these come from constants and variables used
@@ -48,33 +48,37 @@ isa_ok($externals, 'ARRAY', 'parse_exter
# TEST
isa_ok($externals->[0], '_p_svn_wc_external_item2_t');
# TEST
-ok($externals->[0]->target_dir(), 'project1');
+is($externals->[0]->target_dir(), 'project1');
# TEST
-ok($externals->[0]->url(), 'http://svn.example.com/repos/project1');
+is($externals->[0]->url(), 'http://svn.example.com/repos/project1');
# TEST
-ok($externals->[0]->revision(), 'svn_opt_revision_t');
-# TEST
-ok($externals->[0]->revision()->kind(), $SVN::Core::svn_opt_revision_head);
-# TEST
-ok($externals->[0]->peg_revision(), 'svn_opt_revision_t');
-# TEST
-ok($externals->[0]->peg_revision()->kind(),
- $SVN::Core::svn_opt_revision_head);
+isa_ok($externals->[0]->revision(), '_p_svn_opt_revision_t');
+# XTEST
+# This and the other similiarly commented out tests below are
+# not working right now. Need to figure out why but when you try
+# to access the fields in the _p_svn_opt_revision_t type it
+# gets corrupted.
+#is($externals->[0]->revision->kind, $SVN::Core::opt_revision_head);
+# TEST
+isa_ok($externals->[0]->peg_revision(), '_p_svn_opt_revision_t');
+# XTEST
+#is($externals->[0]->peg_revision()->kind(),
+# $SVN::Core::opt_revision_head);
# Check the second member
# TEST
-isa_ok($externals->[0], '_p_svn_wc_external_item2_t');
-# TEST
-ok($externals->[0]->target_dir(), 'Project 2');
-# TEST
-ok($externals->[0]->url(), '^/repos/project2');
+isa_ok($externals->[1], '_p_svn_wc_external_item2_t');
# TEST
-ok($externals->[0]->revision(), 'svn_opt_revision_t');
+is($externals->[1]->target_dir(), 'Project 2');
# TEST
-ok($externals->[0]->revision()->kind(), $SVN::Core::svn_opt_revision_head);
+is($externals->[1]->url(), '^/repos/project2');
# TEST
-ok($externals->[0]->peg_revision(), 'svn_opt_revision_t');
+isa_ok($externals->[1]->revision(), '_p_svn_opt_revision_t');
+# XTEST
+#is($externals->[1]->revision()->kind(), $SVN::Core::opt_revision_head);
# TEST
-ok($externals->[0]->peg_revision()->kind(),
- $SVN::Core::svn_opt_revision_head);
+isa_ok($externals->[1]->peg_revision(), '_p_svn_opt_revision_t');
+# XTEST
+#is($externals->[1]->peg_revision()->kind(),
+# $SVN::Core::opt_revision_head);