[GitHub] [inlong] leezng commented on a diff in pull request #6546: [INLONG-6542][Dashboard] Optimize stream execution workflow and execution log

[GitBox <gi...@apache.org>]

leezng commented on code in PR #6546:
URL: https://github.com/apache/inlong/pull/6546#discussion_r1023438219


##########
inlong-dashboard/src/pages/GroupDetail/DataStream/index.tsx:
##########
@@ -72,6 +74,10 @@ const Comp = ({ inlongGroupId, readonly, mqType }: Props, ref) => {
     },
   );
 
+  const groupInfo = useRequest(`/group/get/${inlongGroupId}`, {

Review Comment:
   remove `const groupInfo =` ?



##########
inlong-dashboard/src/pages/GroupDetail/DataStream/index.tsx:
##########
@@ -178,11 +184,14 @@ const Comp = ({ inlongGroupId, readonly, mqType }: Props, ref) => {
             <Button type="link" onClick={() => onDelete(record)}>
               {t('basic.Delete')}
             </Button>
-            {record?.status && (record?.status === 120 || record?.status === 130) && (
-              <Button type="link" onClick={() => onWorkflow(record)}>
-                {t('meta.Stream.ExecuteWorkflow')}
-              </Button>
-            )}
+            {record?.status &&
+              ((groupStatus === 130 && record?.status === 100) ||

Review Comment:
   Are the two conditions `groupStatus === 130 && record?.status === 100` and `groupStatus === 130` repeated, and only need `groupStatus === 130`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org