You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/07 13:23:55 UTC
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request
#4204: #4182, ignore showLike context in show columns
tuohai666 opened a new pull request #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204
Fixes #4182.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4204:
#4182, ignore showLike context in show columns
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204#issuecomment-583422268
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204?src=pr&el=h1) Report
> Merging [#4204](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/8f7187bb5b053da8c92e6724c6c74d3648ddce45?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4204 +/- ##
============================================
+ Coverage 60.86% 60.87% +0.01%
Complexity 352 352
============================================
Files 1012 1012
Lines 16920 16916 -4
Branches 2982 2981 -1
============================================
Hits 10298 10298
+ Misses 5970 5966 -4
Partials 652 652
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQUxWaXNpdG9yLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204?src=pr&el=footer). Last update [8f7187b...9fd91d0](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4204?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4204:
#4182, ignore showLike context in show columns
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4204: #4182, ignore showLike context in show columns
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204#issuecomment-583412495
## Pull Request Test Coverage Report for [Build 1644](https://coveralls.io/builds/28592325)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.02%**) to **64.797%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28592325/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28592325) |
| :-- | --: |
| Change from base [Build 9375](https://coveralls.io/builds/28590469): | 0.02% |
| Covered Lines: | 10961 |
| Relevant Lines: | 16916 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4204:
#4182, ignore showLike context in show columns
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204#issuecomment-583412495
## Pull Request Test Coverage Report for [Build 1642](https://coveralls.io/builds/28590418)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.02%**) to **64.797%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28590418/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28590418) |
| :-- | --: |
| Change from base [Build 9375](https://coveralls.io/builds/28590469): | 0.02% |
| Covered Lines: | 10961 |
| Relevant Lines: | 16916 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4204: #4182, ignore showLike context in show columns
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204#discussion_r376452105
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
##########
@@ -40,7 +40,7 @@ showTableStatus
;
showColumns
- : SHOW EXTENDED? FULL? (COLUMNS | FIELDS) fromTable fromSchema? (showLike | showWhereClause_)?
+ : SHOW EXTENDED? FULL? (COLUMNS | FIELDS) fromTable fromSchema? (showLike_ | showWhereClause_)?
Review comment:
`showLike_` and `showLike` can make developer confuse.
It is better to rename `showLike_` to `showColumnLike_`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4204: #4182, ignore showLike context in show columns
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204#issuecomment-583412495
## Pull Request Test Coverage Report for [Build 9377](https://coveralls.io/builds/28590946)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.02%**) to **64.791%**
---
| Totals | [](https://coveralls.io/builds/28590946) |
| :-- | --: |
| Change from base [Build 9375](https://coveralls.io/builds/28590469): | 0.02% |
| Covered Lines: | 10960 |
| Relevant Lines: | 16916 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull
request #4204: #4182, ignore showLike context in show columns
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #4204: #4182, ignore showLike context in show columns
URL: https://github.com/apache/incubator-shardingsphere/pull/4204#discussion_r376455235
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
##########
@@ -40,7 +40,7 @@ showTableStatus
;
showColumns
- : SHOW EXTENDED? FULL? (COLUMNS | FIELDS) fromTable fromSchema? (showLike | showWhereClause_)?
+ : SHOW EXTENDED? FULL? (COLUMNS | FIELDS) fromTable fromSchema? (showLike_ | showWhereClause_)?
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services