[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #6823: [TIR] Make loop unrolling in LoopPartition optional

[GitBox <gi...@apache.org>]

ANSHUMAN87 commented on a change in pull request #6823:
URL: https://github.com/apache/incubator-tvm/pull/6823#discussion_r517112153



##########
File path: src/tir/transforms/loop_partition.cc
##########
@@ -40,9 +40,11 @@ namespace tir {
 
 struct LoopPartitionConfigNode : public tvm::AttrsNode<LoopPartitionConfigNode> {
   bool partition_const_loop;
+  bool unroll;

Review comment:
       If we want a config point here. I think it is good to start with optional config, not mandatory config.
   I think it is good, if keep option like no_unroll_single_iter_loop = False

##########
File path: src/tir/transforms/loop_partition.cc
##########
@@ -402,6 +404,7 @@ class LoopPartitioner : public StmtMutator {
   std::unordered_map<const VarNode*, IntSet> relax_map_;
   arith::Analyzer analyzer_;
   CandidateSelector selector;
+  bool unroll_;

Review comment:
       Please change the name as per last comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org