You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/15 18:16:55 UTC
Re: Review Request 60626: Eliminate os::shell calls from HDFS for
Windows compatibility.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/#review182977
-----------------------------------------------------------
src/hdfs/hdfs.cpp
Lines 118-120 (original), 118-121 (patched)
<https://reviews.apache.org/r/60626/#comment258952>
This needs to have further error handling. You can't just `get().get()`, as it may error.
Also, this subtly changed the style; there's a floating open curly brace.
- Andrew Schwartzmeyer
On July 3, 2017, 12:34 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60626/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 12:34 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Eliminate os::shell calls from HDFS for Windows compatibility.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
>
>
> Diff: https://reviews.apache.org/r/60626/diff/1/
>
>
> Testing
> -------
>
> See upstream
>
>
> Thanks,
>
> Jeff Coffler
>
>