You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2020/12/28 11:30:46 UTC

[maven-invoker] branch MINVOKER-269 created (now d55f6ac)

This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a change to branch MINVOKER-269
in repository https://gitbox.apache.org/repos/asf/maven-invoker.git.


      at d55f6ac  [MINVOKER-269] add 'quiet' flag

This branch includes the following new commits:

     new d55f6ac  [MINVOKER-269] add 'quiet' flag

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[maven-invoker] 01/01: [MINVOKER-269] add 'quiet' flag

Posted by sl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch MINVOKER-269
in repository https://gitbox.apache.org/repos/asf/maven-invoker.git

commit d55f6acab54150db5c8a9c79acf40b0728b72efb
Author: Henrik Albers Kronborg <ha...@universal-robots.com>
AuthorDate: Tue Aug 25 07:52:16 2020 +0200

    [MINVOKER-269] add 'quiet' flag
    
    Allow for using the -q (--quiet) flag in Maven invocations
    
    Closes #6
---
 .../shared/invoker/DefaultInvocationRequest.java      | 19 +++++++++++++++++++
 .../maven/shared/invoker/InvocationRequest.java       | 17 +++++++++++++++++
 .../maven/shared/invoker/MavenCommandLineBuilder.java |  5 +++++
 .../shared/invoker/MavenCommandLineBuilderTest.java   |  9 +++++++++
 4 files changed, 50 insertions(+)

diff --git a/src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java b/src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java
index 0b71906..c2b0bf4 100644
--- a/src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java
+++ b/src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java
@@ -105,6 +105,8 @@ public class DefaultInvocationRequest
 
     private int timeoutInSeconds = NO_TIMEOUT;
 
+    private boolean quiet;
+
     public File getBaseDirectory()
     {
         return basedir;
@@ -597,4 +599,21 @@ public class DefaultInvocationRequest
     {
         this.timeoutInSeconds = timeoutInSeconds;
     }
+
+    /**
+     * {@inheritDoc}
+     */
+    public boolean isQuiet()
+    {
+        return quiet;
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    public InvocationRequest setQuiet( boolean quiet )
+    {
+        this.quiet = quiet;
+        return this;
+    }
 }
diff --git a/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java b/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java
index d867331..2136e10 100644
--- a/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java
+++ b/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java
@@ -310,6 +310,14 @@ public interface InvocationRequest
      */
     String getThreads();
 
+    /**
+     * Gets the quiet mode of the Maven invocation. By default, Maven is executed in normal mode.
+     *
+     * @return <code>true</code> if Maven should be executed in quiet mode, <code>false</code> if normal mode should
+     *         be used.
+     */
+    boolean isQuiet();
+
     // ----------------------------------------------------------------------
     // Reactor Failure Mode
     // ----------------------------------------------------------------------
@@ -718,6 +726,15 @@ public interface InvocationRequest
     InvocationRequest setBuilder( String id );
 
     /**
+     * Sets the quiet mode of the Maven invocation. Equivalent of {@code -q} and {@code --quiet}
+     *
+     * @param quiet <code>true</code> if Maven should be executed in quiet mode, <code>false</code> if the normal mode
+     *            should be used.
+     * @return This invocation request.
+     */
+    InvocationRequest setQuiet( boolean quiet );
+
+    /**
      * Get the current set builder strategy id equivalent of {@code --builder id}. <b>Note. This is available since
      * Maven 3.2.1</b>
      * 
diff --git a/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java b/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
index 57021a0..896848b 100644
--- a/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
+++ b/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
@@ -505,6 +505,11 @@ public class MavenCommandLineBuilder
         {
             cli.createArg().setValue( request.getBuilder() );
         }
+
+        if ( request.isQuiet() )
+        {
+            cli.createArg().setValue( "-q" );
+        }
     }
 
     protected void setThreads( InvocationRequest request, Commandline cli )
diff --git a/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java b/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
index f9e29bb..fb49c7f 100644
--- a/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
+++ b/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
@@ -317,6 +317,15 @@ public class MavenCommandLineBuilderTest
     }
 
     @Test
+    public void testShouldSetQuietFlagFromRequest()
+    {
+
+        tcb.setFlags( newRequest().setQuiet( true ), cli );
+
+        assertArgumentsPresent( cli, Collections.singleton( "-q" ));
+    }
+
+    @Test
     public void testDebugOptionShouldMaskShowErrorsOption()
     {