You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/09 04:28:34 UTC

[GitHub] [druid] maytasm commented on pull request #11892: catch throwable because calcite is throwing an error not exception

maytasm commented on pull request #11892:
URL: https://github.com/apache/druid/pull/11892#issuecomment-963807513


   Can you add a test for this?
   You can do something similar to SqlResourceTest#testUnsupportedQueryThrowsExceptionWithFilterResponse but replacing `EasyMock.expect(badQuery.getParameterList()).andThrow(new QueryUnsupportedException(errorMessage));` with `EasyMock.expect(badQuery.getParameterList()).andThrow(new Error(errorMessage));`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org