[GitHub] [qpid-dispatch] grs commented on a change in pull request #453: DISPATCH-1278: initial support for prometheus metrics export

[GitBox <gi...@apache.org>]

grs commented on a change in pull request #453: DISPATCH-1278: initial support for prometheus metrics export
URL: https://github.com/apache/qpid-dispatch/pull/453#discussion_r263009063
 
 

 ##########
 File path: src/http-libwebsockets.c
 ##########
 @@ -361,6 +386,135 @@ static void connection_wake(qd_connection_t *qd_conn)
     }
 }
 
+static void handle_stats_results(void *context, qdr_global_stats_t *results)
+{
+    stats_t* stats = (stats_t*) context;
+    qd_http_server_t *hs = stats->server;
+    if (hs) {
+        work_t w = { W_HANDLE_STATS, stats->wsi };
+        work_push(hs, w);
 
 Review comment:
   Agreed. What's the call for doing that can you remind me?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org