You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/19 01:35:48 UTC
[kudu-CR] [examples] make client examples-test.sh pass
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19766
Change subject: [examples] make client_examples-test.sh pass
......................................................................
[examples] make client_examples-test.sh pass
Since the newly introduced non_unique_primary_key.cc example uses
features not available in C++98, an extra flag is needed if compiling
the example with legacy compilers. Otherwise, client_examples-test.sh
would fail while trying to compile it.
Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
---
M examples/cpp/CMakeLists.txt
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19766/1
--
To view, visit http://gerrit.cloudera.org:8080/19766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19766
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [examples] make client examples-test.sh pass
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19766 )
Change subject: [examples] make client_examples-test.sh pass
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19766
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 01:49:17 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] make client examples-test.sh pass
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19766 )
Change subject: [examples] make client_examples-test.sh pass
......................................................................
[examples] make client_examples-test.sh pass
Since the newly introduced non_unique_primary_key.cc example uses
features not available in C++98, an extra flag is needed if compiling
the example with legacy compilers. Otherwise, client_examples-test.sh
would fail while trying to compile it.
Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Reviewed-on: http://gerrit.cloudera.org:8080/19766
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Kudu Jenkins
---
M examples/cpp/CMakeLists.txt
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19766
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [examples] make client examples-test.sh pass
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19766 )
Change subject: [examples] make client_examples-test.sh pass
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19766
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 01:46:05 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] make client examples-test.sh pass
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19766 )
Change subject: [examples] make client_examples-test.sh pass
......................................................................
Patch Set 1: -Verified
--
To view, visit http://gerrit.cloudera.org:8080/19766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19766
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 01:49:53 +0000
Gerrit-HasComments: No