(incubator-uniffle) branch master updated: [#2136][FOLLOWUP] improvement(server,coordinator): Modify the path of update conf rest api (#2235)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maobaolong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new cddc16565 [#2136][FOLLOWUP] improvement(server,coordinator): Modify the path of update conf rest api (#2235)
cddc16565 is described below

commit cddc165658c01427511e3eb9105a49543ba77ad0
Author: maobaolong <ba...@tencent.com>
AuthorDate: Tue Nov 5 15:44:25 2024 +0800

    [#2136][FOLLOWUP] improvement(server,coordinator): Modify the path of update conf rest api (#2235)
    
    ### What changes were proposed in this pull request?
    
    Modify the path of update conf rest api
    
    ### Why are the changes needed?
    
    To make it clear to show this is a temp update, do not update the config file.
    
    ### Does this PR introduce _any_ user-facing change?
    
    Path modified to
    
    `http://localhost:19948/api/shuffleServer/confOps/update` ->
    `http://localhost:19948/api/shuffleserver/conf/ops/temp/update`
    
    ### How was this patch tested?
    
    Tested Locally.
    
    ```
    ➜  ~ curl -X POST http://localhost:19948/api/shuffleServer/conf/ops/temp/update \
    -H "Content-Type: application/json" \
    -d '{"update":{"rss.server.flush.localfile.threadPool.size": "122", "rss.server.flush.thread.alive": "112", "rss.rpc.executor.size": "123"}}'
    temporarily effective until restart: Update successfully%
    ```
---
 .../java/org/apache/uniffle/common/web/resource/ConfOpsResource.java  | 4 ++--
 .../uniffle/coordinator/web/resource/CoordinatorServerResource.java   | 2 +-
 .../java/org/apache/uniffle/server/web/resource/ServerResource.java   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/common/src/main/java/org/apache/uniffle/common/web/resource/ConfOpsResource.java b/common/src/main/java/org/apache/uniffle/common/web/resource/ConfOpsResource.java
index ea117aa75..486e4ded7 100644
--- a/common/src/main/java/org/apache/uniffle/common/web/resource/ConfOpsResource.java
+++ b/common/src/main/java/org/apache/uniffle/common/web/resource/ConfOpsResource.java
@@ -33,7 +33,7 @@ import org.slf4j.LoggerFactory;
 import org.apache.uniffle.common.ReconfigurableRegistry;
 import org.apache.uniffle.common.config.RssConf;
 
-@Path("/confOps")
+@Path("/conf/ops")
 public class ConfOpsResource {
   private static final Logger LOG = LoggerFactory.getLogger(ConfOpsResource.class);
   private static final String WARNING_MSG = "temporarily effective until restart";
@@ -43,7 +43,7 @@ public class ConfOpsResource {
 
   @Authorization
   @POST
-  @Path("/update")
+  @Path("/temp/update")
   @Consumes(MediaType.APPLICATION_JSON)
   public String update(ConfVO updateConfigs) {
     LOG.info("Dynamic updating {}", updateConfigs);
diff --git a/coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/CoordinatorServerResource.java b/coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/CoordinatorServerResource.java
index 7ea69abf3..57822b516 100644
--- a/coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/CoordinatorServerResource.java
+++ b/coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/CoordinatorServerResource.java
@@ -112,7 +112,7 @@ public class CoordinatorServerResource extends BaseResource {
     return builder.toString();
   }
 
-  @Path("/confOps")
+  @Path("/conf/ops")
   public Class<ConfOpsResource> getConfOps() {
     return ConfOpsResource.class;
   }
diff --git a/server/src/main/java/org/apache/uniffle/server/web/resource/ServerResource.java b/server/src/main/java/org/apache/uniffle/server/web/resource/ServerResource.java
index 37e732cf2..422530e3f 100644
--- a/server/src/main/java/org/apache/uniffle/server/web/resource/ServerResource.java
+++ b/server/src/main/java/org/apache/uniffle/server/web/resource/ServerResource.java
@@ -77,7 +77,7 @@ public class ServerResource extends BaseResource {
     return builder.toString();
   }
 
-  @Path("/confOps")
+  @Path("/conf/ops")
   public Class<ConfOpsResource> getConfOps() {
     return ConfOpsResource.class;
   }