You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/23 10:01:15 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
MaxGekk opened a new pull request #28905:
URL: https://github.com/apache/spark/pull/28905
### What changes were proposed in this pull request?
Add benchmarks for interval constructor `make_interval` and measure perf of 4 cases:
1. Constant (year, month)
2. Constant (week, day)
3. Constant (hour, minute, second, second fraction)
4. All fields are NOT constant.
### Why are the changes needed?
To have a base line for future perf improvements of `make_interval`, and to prevent perf regressions in the future.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running `IntervalBenchmark` via:
```
$ SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.IntervalBenchmark"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649035182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648515482
**[Test build #124433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124433/testReport)** for PR 28905 at commit [`27c297e`](https://github.com/apache/spark/commit/27c297e32a7540dd43641a5ee2c49450821b5a12).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL][TESTS] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650658827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648359008
**[Test build #124430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124430/testReport)** for PR 28905 at commit [`ec47daf`](https://github.com/apache/spark/commit/ec47daf0ac76c9530f0246c21e71a76e15e696b9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649035182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648516076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28905:
URL: https://github.com/apache/spark/pull/28905#discussion_r444115259
##########
File path: sql/core/benchmarks/IntervalBenchmark-jdk11-results.txt
##########
@@ -1,29 +1,39 @@
-Java HotSpot(TM) 64-Bit Server VM 11.0.5+10-LTS on Mac OS X 10.15.3
-Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux 4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-prepare string w/ interval 448 469 20 2.2 447.6 1.0X
-prepare string w/o interval 405 409 4 2.5 404.6 1.1X
-1 units w/ interval 321 328 6 3.1 321.4 1.4X
-1 units w/o interval 303 307 4 3.3 303.1 1.5X
-2 units w/ interval 445 458 12 2.2 444.6 1.0X
-2 units w/o interval 416 424 10 2.4 416.2 1.1X
-3 units w/ interval 1006 1012 8 1.0 1006.4 0.4X
-3 units w/o interval 1240 1249 8 0.8 1239.6 0.4X
-4 units w/ interval 1295 1418 106 0.8 1295.4 0.3X
-4 units w/o interval 1172 1188 15 0.9 1171.6 0.4X
-5 units w/ interval 1326 1335 11 0.8 1325.6 0.3X
-5 units w/o interval 1309 1336 44 0.8 1308.7 0.3X
-6 units w/ interval 1441 1464 29 0.7 1441.0 0.3X
-6 units w/o interval 1350 1369 17 0.7 1350.1 0.3X
-7 units w/ interval 1606 1669 99 0.6 1605.6 0.3X
-7 units w/o interval 1546 1557 12 0.6 1546.3 0.3X
-8 units w/ interval 1771 1875 120 0.6 1770.6 0.3X
-8 units w/o interval 1775 1789 13 0.6 1775.2 0.3X
-9 units w/ interval 2126 2757 849 0.5 2126.4 0.2X
-9 units w/o interval 2053 2070 21 0.5 2053.3 0.2X
-10 units w/ interval 2209 2243 30 0.5 2209.1 0.2X
-10 units w/o interval 2400 2702 365 0.4 2400.2 0.2X
-11 units w/ interval 2616 2699 72 0.4 2616.5 0.2X
-11 units w/o interval 3218 3380 195 0.3 3218.4 0.1X
+prepare string w/ interval 744 823 81 1.3 744.3 1.0X
+prepare string w/o interval 612 620 12 1.6 611.9 1.2X
+1 units w/ interval 518 525 8 1.9 517.5 1.4X
+1 units w/o interval 475 477 2 2.1 475.0 1.6X
+2 units w/ interval 681 727 76 1.5 680.9 1.1X
+2 units w/o interval 654 660 10 1.5 653.5 1.1X
+3 units w/ interval 1319 1325 10 0.8 1318.6 0.6X
+3 units w/o interval 1330 1332 3 0.8 1329.7 0.6X
+4 units w/ interval 1723 1725 4 0.6 1722.8 0.4X
+4 units w/o interval 1723 1725 2 0.6 1723.1 0.4X
+5 units w/ interval 1906 1921 15 0.5 1906.4 0.4X
+5 units w/o interval 1902 1918 20 0.5 1901.9 0.4X
+6 units w/ interval 2109 2118 8 0.5 2108.8 0.4X
+6 units w/o interval 2102 2105 4 0.5 2102.3 0.4X
+7 units w/ interval 2324 2325 1 0.4 2324.5 0.3X
+7 units w/o interval 2381 2384 3 0.4 2380.9 0.3X
+8 units w/ interval 2460 2483 21 0.4 2459.6 0.3X
+8 units w/o interval 2452 2459 10 0.4 2452.3 0.3X
+9 units w/ interval 2714 2720 9 0.4 2714.3 0.3X
+9 units w/o interval 2707 2719 10 0.4 2707.4 0.3X
+10 units w/ interval 2860 2863 3 0.3 2859.8 0.3X
+10 units w/o interval 2853 2863 11 0.4 2852.9 0.3X
+11 units w/ interval 3156 3160 7 0.3 3155.5 0.2X
+11 units w/o interval 3169 3179 10 0.3 3168.8 0.2X
+
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux 4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
+make_interval(): Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+prepare make_interval() 3396 3410 13 0.3 3395.6 1.0X
+make_interval(0,1,2,3,4,5,50.123456) 132 141 8 7.6 132.3 25.7X
Review comment:
I had to remove spaces otherwise results in the table are shifted so much to the right and not aligned to column names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28905:
URL: https://github.com/apache/spark/pull/28905#discussion_r444115259
##########
File path: sql/core/benchmarks/IntervalBenchmark-jdk11-results.txt
##########
@@ -1,29 +1,39 @@
-Java HotSpot(TM) 64-Bit Server VM 11.0.5+10-LTS on Mac OS X 10.15.3
-Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux 4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-prepare string w/ interval 448 469 20 2.2 447.6 1.0X
-prepare string w/o interval 405 409 4 2.5 404.6 1.1X
-1 units w/ interval 321 328 6 3.1 321.4 1.4X
-1 units w/o interval 303 307 4 3.3 303.1 1.5X
-2 units w/ interval 445 458 12 2.2 444.6 1.0X
-2 units w/o interval 416 424 10 2.4 416.2 1.1X
-3 units w/ interval 1006 1012 8 1.0 1006.4 0.4X
-3 units w/o interval 1240 1249 8 0.8 1239.6 0.4X
-4 units w/ interval 1295 1418 106 0.8 1295.4 0.3X
-4 units w/o interval 1172 1188 15 0.9 1171.6 0.4X
-5 units w/ interval 1326 1335 11 0.8 1325.6 0.3X
-5 units w/o interval 1309 1336 44 0.8 1308.7 0.3X
-6 units w/ interval 1441 1464 29 0.7 1441.0 0.3X
-6 units w/o interval 1350 1369 17 0.7 1350.1 0.3X
-7 units w/ interval 1606 1669 99 0.6 1605.6 0.3X
-7 units w/o interval 1546 1557 12 0.6 1546.3 0.3X
-8 units w/ interval 1771 1875 120 0.6 1770.6 0.3X
-8 units w/o interval 1775 1789 13 0.6 1775.2 0.3X
-9 units w/ interval 2126 2757 849 0.5 2126.4 0.2X
-9 units w/o interval 2053 2070 21 0.5 2053.3 0.2X
-10 units w/ interval 2209 2243 30 0.5 2209.1 0.2X
-10 units w/o interval 2400 2702 365 0.4 2400.2 0.2X
-11 units w/ interval 2616 2699 72 0.4 2616.5 0.2X
-11 units w/o interval 3218 3380 195 0.3 3218.4 0.1X
+prepare string w/ interval 744 823 81 1.3 744.3 1.0X
+prepare string w/o interval 612 620 12 1.6 611.9 1.2X
+1 units w/ interval 518 525 8 1.9 517.5 1.4X
+1 units w/o interval 475 477 2 2.1 475.0 1.6X
+2 units w/ interval 681 727 76 1.5 680.9 1.1X
+2 units w/o interval 654 660 10 1.5 653.5 1.1X
+3 units w/ interval 1319 1325 10 0.8 1318.6 0.6X
+3 units w/o interval 1330 1332 3 0.8 1329.7 0.6X
+4 units w/ interval 1723 1725 4 0.6 1722.8 0.4X
+4 units w/o interval 1723 1725 2 0.6 1723.1 0.4X
+5 units w/ interval 1906 1921 15 0.5 1906.4 0.4X
+5 units w/o interval 1902 1918 20 0.5 1901.9 0.4X
+6 units w/ interval 2109 2118 8 0.5 2108.8 0.4X
+6 units w/o interval 2102 2105 4 0.5 2102.3 0.4X
+7 units w/ interval 2324 2325 1 0.4 2324.5 0.3X
+7 units w/o interval 2381 2384 3 0.4 2380.9 0.3X
+8 units w/ interval 2460 2483 21 0.4 2459.6 0.3X
+8 units w/o interval 2452 2459 10 0.4 2452.3 0.3X
+9 units w/ interval 2714 2720 9 0.4 2714.3 0.3X
+9 units w/o interval 2707 2719 10 0.4 2707.4 0.3X
+10 units w/ interval 2860 2863 3 0.3 2859.8 0.3X
+10 units w/o interval 2853 2863 11 0.4 2852.9 0.3X
+11 units w/ interval 3156 3160 7 0.3 3155.5 0.2X
+11 units w/o interval 3169 3179 10 0.3 3168.8 0.2X
+
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux 4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
+make_interval(): Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+prepare make_interval() 3396 3410 13 0.3 3395.6 1.0X
+make_interval(0,1,2,3,4,5,50.123456) 132 141 8 7.6 132.3 25.7X
Review comment:
I had to remove spaces otherwise results in the table are shifted so much to the right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648581509
do we need to regenerate the result as https://github.com/apache/spark/pull/28906 is merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648391996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648516076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649034418
**[Test build #124499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124499/testReport)** for PR 28905 at commit [`3c5b604`](https://github.com/apache/spark/commit/3c5b6041477194a855667059629d0fe4b0258b23).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648391996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648359008
**[Test build #124430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124430/testReport)** for PR 28905 at commit [`ec47daf`](https://github.com/apache/spark/commit/ec47daf0ac76c9530f0246c21e71a76e15e696b9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649034418
**[Test build #124499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124499/testReport)** for PR 28905 at commit [`3c5b604`](https://github.com/apache/spark/commit/3c5b6041477194a855667059629d0fe4b0258b23).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL][TESTS] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650658676
**[Test build #124579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124579/testReport)** for PR 28905 at commit [`3c5b604`](https://github.com/apache/spark/commit/3c5b6041477194a855667059629d0fe4b0258b23).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28905:
URL: https://github.com/apache/spark/pull/28905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648042396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648391402
**[Test build #124433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124433/testReport)** for PR 28905 at commit [`27c297e`](https://github.com/apache/spark/commit/27c297e32a7540dd43641a5ee2c49450821b5a12).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648355907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648482466
**[Test build #124430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124430/testReport)** for PR 28905 at commit [`ec47daf`](https://github.com/apache/spark/commit/ec47daf0ac76c9530f0246c21e71a76e15e696b9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649147088
**[Test build #124499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124499/testReport)** for PR 28905 at commit [`3c5b604`](https://github.com/apache/spark/commit/3c5b6041477194a855667059629d0fe4b0258b23).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648586569
@cloud-fan I will re-generate results tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649147733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650701112
**[Test build #124579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124579/testReport)** for PR 28905 at commit [`3c5b604`](https://github.com/apache/spark/commit/3c5b6041477194a855667059629d0fe4b0258b23).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649377831
@HyukjinKwon @cloud-fan Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648483090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648213152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648041878
**[Test build #124414 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124414/testReport)** for PR 28905 at commit [`6f64bf0`](https://github.com/apache/spark/commit/6f64bf0352cef733d75360b1ff8e13a38450d18a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650701364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-649147733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650701364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28905: [SPARK-32071][SQL][TESTS] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650657940
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28905: [SPARK-32071][SQL][TESTS] Add `make_interval` benchmark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650658676
**[Test build #124579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124579/testReport)** for PR 28905 at commit [`3c5b604`](https://github.com/apache/spark/commit/3c5b6041477194a855667059629d0fe4b0258b23).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648042396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648211624
**[Test build #124414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124414/testReport)** for PR 28905 at commit [`6f64bf0`](https://github.com/apache/spark/commit/6f64bf0352cef733d75360b1ff8e13a38450d18a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648041878
**[Test build #124414 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124414/testReport)** for PR 28905 at commit [`6f64bf0`](https://github.com/apache/spark/commit/6f64bf0352cef733d75360b1ff8e13a38450d18a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28905:
URL: https://github.com/apache/spark/pull/28905#discussion_r444153454
##########
File path: sql/core/benchmarks/IntervalBenchmark-jdk11-results.txt
##########
@@ -1,29 +1,39 @@
-Java HotSpot(TM) 64-Bit Server VM 11.0.5+10-LTS on Mac OS X 10.15.3
-Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux 4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-prepare string w/ interval 448 469 20 2.2 447.6 1.0X
-prepare string w/o interval 405 409 4 2.5 404.6 1.1X
-1 units w/ interval 321 328 6 3.1 321.4 1.4X
-1 units w/o interval 303 307 4 3.3 303.1 1.5X
-2 units w/ interval 445 458 12 2.2 444.6 1.0X
-2 units w/o interval 416 424 10 2.4 416.2 1.1X
-3 units w/ interval 1006 1012 8 1.0 1006.4 0.4X
-3 units w/o interval 1240 1249 8 0.8 1239.6 0.4X
-4 units w/ interval 1295 1418 106 0.8 1295.4 0.3X
-4 units w/o interval 1172 1188 15 0.9 1171.6 0.4X
-5 units w/ interval 1326 1335 11 0.8 1325.6 0.3X
-5 units w/o interval 1309 1336 44 0.8 1308.7 0.3X
-6 units w/ interval 1441 1464 29 0.7 1441.0 0.3X
-6 units w/o interval 1350 1369 17 0.7 1350.1 0.3X
-7 units w/ interval 1606 1669 99 0.6 1605.6 0.3X
-7 units w/o interval 1546 1557 12 0.6 1546.3 0.3X
-8 units w/ interval 1771 1875 120 0.6 1770.6 0.3X
-8 units w/o interval 1775 1789 13 0.6 1775.2 0.3X
-9 units w/ interval 2126 2757 849 0.5 2126.4 0.2X
-9 units w/o interval 2053 2070 21 0.5 2053.3 0.2X
-10 units w/ interval 2209 2243 30 0.5 2209.1 0.2X
-10 units w/o interval 2400 2702 365 0.4 2400.2 0.2X
-11 units w/ interval 2616 2699 72 0.4 2616.5 0.2X
-11 units w/o interval 3218 3380 195 0.3 3218.4 0.1X
+prepare string w/ interval 744 823 81 1.3 744.3 1.0X
+prepare string w/o interval 612 620 12 1.6 611.9 1.2X
+1 units w/ interval 518 525 8 1.9 517.5 1.4X
+1 units w/o interval 475 477 2 2.1 475.0 1.6X
+2 units w/ interval 681 727 76 1.5 680.9 1.1X
+2 units w/o interval 654 660 10 1.5 653.5 1.1X
+3 units w/ interval 1319 1325 10 0.8 1318.6 0.6X
+3 units w/o interval 1330 1332 3 0.8 1329.7 0.6X
+4 units w/ interval 1723 1725 4 0.6 1722.8 0.4X
+4 units w/o interval 1723 1725 2 0.6 1723.1 0.4X
+5 units w/ interval 1906 1921 15 0.5 1906.4 0.4X
+5 units w/o interval 1902 1918 20 0.5 1901.9 0.4X
+6 units w/ interval 2109 2118 8 0.5 2108.8 0.4X
+6 units w/o interval 2102 2105 4 0.5 2102.3 0.4X
+7 units w/ interval 2324 2325 1 0.4 2324.5 0.3X
+7 units w/o interval 2381 2384 3 0.4 2380.9 0.3X
+8 units w/ interval 2460 2483 21 0.4 2459.6 0.3X
+8 units w/o interval 2452 2459 10 0.4 2452.3 0.3X
+9 units w/ interval 2714 2720 9 0.4 2714.3 0.3X
+9 units w/o interval 2707 2719 10 0.4 2707.4 0.3X
+10 units w/ interval 2860 2863 3 0.3 2859.8 0.3X
+10 units w/o interval 2853 2863 11 0.4 2852.9 0.3X
+11 units w/ interval 3156 3160 7 0.3 3155.5 0.2X
+11 units w/o interval 3169 3179 10 0.3 3168.8 0.2X
+
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux 4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
+make_interval(): Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+prepare make_interval() 3396 3410 13 0.3 3395.6 1.0X
+make_interval(0,1,2,3,4,5,50.123456) 132 141 8 7.6 132.3 25.7X
Review comment:
This PR https://github.com/apache/spark/pull/28906 fixes the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648391402
**[Test build #124433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124433/testReport)** for PR 28905 at commit [`27c297e`](https://github.com/apache/spark/commit/27c297e32a7540dd43641a5ee2c49450821b5a12).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL][TESTS] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-650658827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648213152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648389771
@cloud-fan @HyukjinKwon @dongjoon-hyun Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648355907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28905: [SPARK-32071][SQL] Benchmark `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28905:
URL: https://github.com/apache/spark/pull/28905#issuecomment-648483090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org