You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/30 20:33:12 UTC
Review Request 33728: Fix query for active job updates when serving
/updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33728/
-----------------------------------------------------------
Review request for Aurora and Joshua Cohen.
Bugs: AURORA-1231
https://issues.apache.org/jira/browse/AURORA-1231
Repository: aurora
Description
-------
Fix query for active job updates when serving /updates.
Diffs
-----
src/main/resources/scheduler/assets/js/services.js 47820743484da2e097651a829386a4abc72744eb
Diff: https://reviews.apache.org/r/33728/diff/
Testing
-------
Manually in vagrant :-/
File Attachments
----------------
/updates
https://reviews.apache.org/media/uploaded/files/2015/04/30/c966cca3-9fa4-4e15-89fb-5aae44d5302e__Screenshot_from_2015-04-30_113250.png
Thanks,
Bill Farner
Re: Review Request 33728: Fix query for active job updates when
serving /updates.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33728/#review82176
-----------------------------------------------------------
Master (f77daf7) is red with this patch.
./build-support/jenkins/build.sh
:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
'' is defined but never used. (/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/services.js:28:5)
> */
:jsHint FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':jsHint'.
> Process 'command '/home/jenkins/tools/java/jdk1.7.0_25-32/bin/java'' finished with non-zero exit value 2
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 46.699 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 30, 2015, 6:33 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33728/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 6:33 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1231
> https://issues.apache.org/jira/browse/AURORA-1231
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix query for active job updates when serving /updates.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/js/services.js 47820743484da2e097651a829386a4abc72744eb
>
> Diff: https://reviews.apache.org/r/33728/diff/
>
>
> Testing
> -------
>
> Manually in vagrant :-/
>
>
> File Attachments
> ----------------
>
> /updates
> https://reviews.apache.org/media/uploaded/files/2015/04/30/c966cca3-9fa4-4e15-89fb-5aae44d5302e__Screenshot_from_2015-04-30_113250.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33728: Fix query for active job updates when
serving /updates.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33728/#review82187
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On April 30, 2015, 6:59 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33728/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 6:59 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1231
> https://issues.apache.org/jira/browse/AURORA-1231
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix query for active job updates when serving /updates.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/js/services.js 47820743484da2e097651a829386a4abc72744eb
>
> Diff: https://reviews.apache.org/r/33728/diff/
>
>
> Testing
> -------
>
> Manually in vagrant :-/
>
>
> File Attachments
> ----------------
>
> /updates
> https://reviews.apache.org/media/uploaded/files/2015/04/30/c966cca3-9fa4-4e15-89fb-5aae44d5302e__Screenshot_from_2015-04-30_113250.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33728: Fix query for active job updates when
serving /updates.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33728/#review82181
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On April 30, 2015, 6:59 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33728/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 6:59 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1231
> https://issues.apache.org/jira/browse/AURORA-1231
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix query for active job updates when serving /updates.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/js/services.js 47820743484da2e097651a829386a4abc72744eb
>
> Diff: https://reviews.apache.org/r/33728/diff/
>
>
> Testing
> -------
>
> Manually in vagrant :-/
>
>
> File Attachments
> ----------------
>
> /updates
> https://reviews.apache.org/media/uploaded/files/2015/04/30/c966cca3-9fa4-4e15-89fb-5aae44d5302e__Screenshot_from_2015-04-30_113250.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33728: Fix query for active job updates when
serving /updates.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33728/#review82180
-----------------------------------------------------------
Master (f77daf7) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 30, 2015, 6:59 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33728/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 6:59 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1231
> https://issues.apache.org/jira/browse/AURORA-1231
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix query for active job updates when serving /updates.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/js/services.js 47820743484da2e097651a829386a4abc72744eb
>
> Diff: https://reviews.apache.org/r/33728/diff/
>
>
> Testing
> -------
>
> Manually in vagrant :-/
>
>
> File Attachments
> ----------------
>
> /updates
> https://reviews.apache.org/media/uploaded/files/2015/04/30/c966cca3-9fa4-4e15-89fb-5aae44d5302e__Screenshot_from_2015-04-30_113250.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33728: Fix query for active job updates when
serving /updates.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33728/
-----------------------------------------------------------
(Updated April 30, 2015, 6:59 p.m.)
Review request for Aurora and Joshua Cohen.
Changes
-------
Fix jshint error.
Bugs: AURORA-1231
https://issues.apache.org/jira/browse/AURORA-1231
Repository: aurora
Description
-------
Fix query for active job updates when serving /updates.
Diffs (updated)
-----
src/main/resources/scheduler/assets/js/services.js 47820743484da2e097651a829386a4abc72744eb
Diff: https://reviews.apache.org/r/33728/diff/
Testing
-------
Manually in vagrant :-/
File Attachments
----------------
/updates
https://reviews.apache.org/media/uploaded/files/2015/04/30/c966cca3-9fa4-4e15-89fb-5aae44d5302e__Screenshot_from_2015-04-30_113250.png
Thanks,
Bill Farner