You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/07 22:16:18 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #16142: [BEAM-13388] Fix broken google cloud dlp test.

tvalentyn commented on a change in pull request #16142:
URL: https://github.com/apache/beam/pull/16142#discussion_r764402958



##########
File path: sdks/python/setup.py
##########
@@ -195,7 +195,7 @@ def get_version():
     'google-cloud-spanner>=1.13.0,<2',
     'grpcio-gcp>=0.2.2,<1',
     # GCP Packages required by ML functionality
-    'google-cloud-dlp>=0.12.0,<4',
+    'google-cloud-dlp>=3.3.1,<4',

Review comment:
       We did regenerate requirements for dlp already. I think we didn't catch this issue in https://github.com/apache/beam/pull/15988 because Dataflow containers still included an older version of DLP. 

##########
File path: sdks/python/setup.py
##########
@@ -195,7 +195,7 @@ def get_version():
     'google-cloud-spanner>=1.13.0,<2',
     'grpcio-gcp>=0.2.2,<1',
     # GCP Packages required by ML functionality
-    'google-cloud-dlp>=0.12.0,<4',
+    'google-cloud-dlp>=3.3.1,<4',

Review comment:
       so integration tests passed on that PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org