[jira] [Comment Edited] (TINKERPOP-1552) C# Gremlin Language Variant

["Florian Hockmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016991#comment-16016991 ] 

Florian Hockmann edited comment on TINKERPOP-1552 at 5/19/17 6:59 AM:
----------------------------------------------------------------------

That's actually how I tried it first, but I had problems with the {{pom.xml}} files. The problem was that the {{dotnet-maven-plugin}} doesn't work with the standard maven project structure with a {{src/main/language}} directory structure. So I had to create a new {{pom}} file for every sub directory from {{gremlin-dotnet}} down to for example {{gremlin-dotnet/src/main/csharp/Gremlin.CSharp}} where {{csharp}} is the parent project of {{Gremlin.CSharp}} and so on. I found all those projects files too confusing. That is why I created instead a _.NET only_ project {{gremlin-dotnet}}. But since I have basically no experience with maven it could also be that it is possible to do it in a much easier way.

Another option would be to use something else instead of the {{dotnet-maven-plugin}} like a simple executor plugin. I personally like the {{dotnet-maven-plugin}} as it integrates .NET very nicely into maven in my opinion, but I am of course also ok with an alternative solution.

Good to here that you didn't run into any problems with the build.


was (Author: florian hockmann):
That's actually how I tried it first, but I had problems with the `pom.xml` files. The problem was that the `dotnet-maven-plugin` doesn't work with the standard maven project structure with a `src/main/language` directory structure. So I had to create a new `pom` file for every sub directory from `gremlin-dotnet` down to for example `gremlin-dotnet/src/main/csharp/Gremlin.CSharp` where `csharp` is the parent project of `Gremlin.CSharp` and so on. I found all those projects files too confusing. That is why I created instead a _.NET only_ project `gremlin-dotnet`. But since I have basically no experience with maven it could also be that it is possible to do it in a much easier way.

Another option would be to use something else instead of the `dotnet-maven-plugin` like a simple executor plugin. I personally like the `dotnet-maven-plugin` as it integrates .NET very nicely into maven in my opinion, but I am of course also ok with an alternative solution.

Good to here that you didn't run into any problems with the build.

> C# Gremlin Language Variant
> ---------------------------
>
>                 Key: TINKERPOP-1552
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language-variant
>    Affects Versions: 3.2.3
>            Reporter: Jorge Bay
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)