[jira] [Commented] (NIFI-505) Build processors to translate from 1 language to another

["Joseph Witt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489865#comment-14489865 ] 

Joseph Witt commented on NIFI-505:
----------------------------------

mark

looks good.  Except need to kill this line:
+        try (final InputStream in = new FileInputStream(new File("C:/dev/notes/yandex-info.txt"))) {

We should not have unit tests which use remote services/etc..  The valid unit test would mock out the remote end and only test 'its own' behavior.  I think we have some of these integration style tests elsewhere too.  

+1 if the testing issue is resolved.

> Build processors to translate from 1 language to another
> --------------------------------------------------------
>
>                 Key: NIFI-505
>                 URL: https://issues.apache.org/jira/browse/NIFI-505
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Mark Payne
>             Fix For: 0.1.0
>
>         Attachments: 0007-NIFI-505-Initial-import-of-language-translation-nar.patch
>
>
> Yandex provides a free translation service (up to X number of translations per time period)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)