You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by adambalogh <gi...@git.apache.org> on 2018/09/07 12:52:01 UTC

[GitHub] spark pull request #22289: [SPARK-25200][YARN] Allow specifying HADOOP_CONF_...

Github user adambalogh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22289#discussion_r215947975
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java ---
    @@ -200,6 +200,7 @@ void addOptionString(List<String> cmd, String options) {
     
         addToClassPath(cp, getenv("HADOOP_CONF_DIR"));
         addToClassPath(cp, getenv("YARN_CONF_DIR"));
    +    addToClassPath(cp, getEffectiveConfig().get("spark.yarn.conf.dir"));
    --- End diff --
    
    @vanzin Did you have time to think about how this config should work?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org