[GitHub] [pulsar] mattisonchao commented on a diff in pull request #15524: [Fix][Txn] Fix transaction redeliver message if ack failed

[GitBox <gi...@apache.org>]

mattisonchao commented on code in PR #15524:
URL: https://github.com/apache/pulsar/pull/15524#discussion_r869817668


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java:
##########
@@ -1052,13 +1052,16 @@ public void testTxnTimeOutInClient() throws Exception{
             Assert.assertTrue(e.getCause().getCause() instanceof TransactionCoordinatorClientException
                     .InvalidTxnStatusException);
         }
+        Message<String> message = null;
         try {
-            Message<String> message = consumer.receive();
+            message = consumer.receive();

Review Comment:
   It feels like adding a timeout to the method avoids getting blocks all the time. But I'm not sure if we have another mechanism to guarantee that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org