You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/02/14 00:27:22 UTC
Review Request 69981: Fixed a flaky test
`MasterQuotaTest.RemoveSingleQuota`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69981/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Bugs: MESOS-9143
https://issues.apache.org/jira/browse/MESOS-9143
Repository: mesos
Description
-------
The test is flaky due to a race between metrics update
and metrics query.
This patch adds clock settle to ensure quota update and
removal are fully processed (including metrics updates) before
continuing with the metrics query.
Diffs
-----
src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a
Diff: https://reviews.apache.org/r/69981/diff/1/
Testing
-------
Test ran continuously without failure
Thanks,
Meng Zhu
Re: Review Request 69981: Fixed a flaky test
`MasterQuotaTest.RemoveSingleQuota`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On Feb. 14, 2019, 9:12 a.m., Benjamin Mahler wrote:
> > src/tests/master_quota_tests.cpp
> > Lines 524-525 (patched)
> > <https://reviews.apache.org/r/69981/diff/2/?file=2125212#file2125212line524>
> >
> > Hm.. we're actually waiting for the 200 OK, is this needed because the http handler doesn't wait for the allocator to finish processing the update?
> >
> > Probably we should spell it out here and below so it's clear
Updated the comment saying we are waiting specifically for the metrics update to finish, which is not on the path for 200 OK.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69981/#review212833
-----------------------------------------------------------
On Feb. 13, 2019, 4:27 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69981/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2019, 4:27 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9143
> https://issues.apache.org/jira/browse/MESOS-9143
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is flaky due to a race between metrics update
> and metrics query.
>
> This patch adds clock settle to ensure quota update and
> removal are fully processed (including metrics updates) before
> continuing with the metrics query.
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a
>
>
> Diff: https://reviews.apache.org/r/69981/diff/2/
>
>
> Testing
> -------
>
> Test ran continuously without failure
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69981: Fixed a flaky test
`MasterQuotaTest.RemoveSingleQuota`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69981/#review212833
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_quota_tests.cpp
Lines 524-525 (patched)
<https://reviews.apache.org/r/69981/#comment298724>
Hm.. we're actually waiting for the 200 OK, is this needed because the http handler doesn't wait for the allocator to finish processing the update?
Probably we should spell it out here and below so it's clear
- Benjamin Mahler
On Feb. 14, 2019, 12:27 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69981/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2019, 12:27 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9143
> https://issues.apache.org/jira/browse/MESOS-9143
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is flaky due to a race between metrics update
> and metrics query.
>
> This patch adds clock settle to ensure quota update and
> removal are fully processed (including metrics updates) before
> continuing with the metrics query.
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a
>
>
> Diff: https://reviews.apache.org/r/69981/diff/2/
>
>
> Testing
> -------
>
> Test ran continuously without failure
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69981: Fixed a flaky test
`MasterQuotaTest.RemoveSingleQuota`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69981/#review212824
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69981]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 14, 2019, 12:27 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69981/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2019, 12:27 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9143
> https://issues.apache.org/jira/browse/MESOS-9143
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is flaky due to a race between metrics update
> and metrics query.
>
> This patch adds clock settle to ensure quota update and
> removal are fully processed (including metrics updates) before
> continuing with the metrics query.
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a
>
>
> Diff: https://reviews.apache.org/r/69981/diff/2/
>
>
> Testing
> -------
>
> Test ran continuously without failure
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69981: Fixed a flaky test
`MasterQuotaTest.RemoveSingleQuota`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69981/#review212819
-----------------------------------------------------------
PASS: Mesos patch 69981 was successfully built and tested.
Reviews applied: `['69981']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2888/mesos-review-69981
- Mesos Reviewbot Windows
On Feb. 14, 2019, 12:27 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69981/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2019, 12:27 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9143
> https://issues.apache.org/jira/browse/MESOS-9143
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is flaky due to a race between metrics update
> and metrics query.
>
> This patch adds clock settle to ensure quota update and
> removal are fully processed (including metrics updates) before
> continuing with the metrics query.
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a
>
>
> Diff: https://reviews.apache.org/r/69981/diff/2/
>
>
> Testing
> -------
>
> Test ran continuously without failure
>
>
> Thanks,
>
> Meng Zhu
>
>