[GitHub] [incubator-superset] kgabryje commented on pull request #11640: fix: Title change made in Edit Chart Properties is not showing on the title

[GitBox <gi...@apache.org>]

kgabryje commented on pull request #11640:
URL: https://github.com/apache/incubator-superset/pull/11640#issuecomment-726356408


   > we made 2 API calls to save chart properties change:
   > <img alt="Screen Shot 2020-11-12 at 11 08 58 AM" width="1182" src="https://user-images.githubusercontent.com/27990562/98984798-8867ba80-24d7-11eb-9b76-f265ad4974c5.png">
   > 
   > Is it really necessary to call 2 different APIs? Dashboard Properties modal did similar work, in my opinion it's a bad design and caused many issues.
   
   It's a bit confusing to me, but optimising API calls wasn't a goal of this PR - I only moved sending a PUT request from edit properties modal to save modal (but only on Explore view - on the list view, PUT request is sent from edit properties modal as before).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org