You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2024/01/29 12:01:16 UTC
[I] reproducible builds: timezone(?) leaks into build artifacts [incubator-pekko-http]
raboof opened a new issue, #457:
URL: https://github.com/apache/incubator-pekko-http/issues/457
while trying to verify the reproducibility of the 1.0.1-RC2 artifacts, I ran into a difference: the jar files' entries (for example for `pekko-parsing_2.13-1.0.1-RC2.jar`) have an extra field of type 0x000a (https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/X000A_NTFS.html) containing file timestamps.
These timestamps are set to `Sat Jan 01 00:00:00 CET 2000` on the staged release, while they are `Sat Jan 01 01:00:00 CET 2000` on my local build - only the hour is different. It almost seems as if the intent was to have a fixed value here, but the timezone of the build machine is leaking into the artifact.
Changing the `TZ` environment variable during the build did not affect the timestamps, but building in a different build environment did produce the same timestamps - I still have to figure out what the relevant difference is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] reproducible builds: timezone(?) leaks into build artifacts [pekko-http]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof closed issue #457: reproducible builds: timezone(?) leaks into build artifacts
URL: https://github.com/apache/pekko-http/issues/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] reproducible builds: timezone(?) leaks into build artifacts [incubator-pekko-http]
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #457:
URL: https://github.com/apache/incubator-pekko-http/issues/457#issuecomment-1914568431
Last time I looked into these kinds of things, I think it was a combination of osgi, sbt-assembly, and sbt-reproducible-builds which created weird fields, but I cannot remember exactly. I remember weird code trying to synthesize these fields regarding the time stamps...
Since these fields seems to use an epoch style encoding of instants, is, what you are observing actually different timestamp longs in the files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] reproducible builds: timezone(?) leaks into build artifacts [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #457:
URL: https://github.com/apache/incubator-pekko-http/issues/457#issuecomment-1914570517
This has affected us for a while. My usual timezone is Dublin but I'm currently in CET. It would be great to sort out where this diff comes from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] reproducible builds: timezone(?) leaks into build artifacts [pekko-http]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on issue #457:
URL: https://github.com/apache/pekko-http/issues/457#issuecomment-2154351361
Checked the 1.1.0-M1 artifacts, those are now reproducible for 2.13, so indeed the fix seems to have the intended effect.
I used:
```
sbt "set ThisBuild / net.bzzt.reproduciblebuilds.ReproducibleBuildsPlugin.reproducibleBuildsCheckResolver := DefaultMavenRepository; shell"
> reproducibleBuildsCheck
```
Filed https://github.com/raboof/sbt-reproducible-builds/issues/323 to make this a little easier
I also tried to reproduce for Scala 3, which showed two further problems:
* #565
* #566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] reproducible builds: timezone(?) leaks into build artifacts [pekko-http]
Posted by "Philippus (via GitHub)" <gi...@apache.org>.
Philippus commented on issue #457:
URL: https://github.com/apache/pekko-http/issues/457#issuecomment-2154065610
Is still still an issue after https://github.com/apache/pekko-http/pull/488 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org