[GitHub] astahlman opened a new pull request #4572: [AIRFLOW-3752] Add/remove user from role via CLI

[GitBox <gi...@apache.org>]

astahlman opened a new pull request #4572: [AIRFLOW-3752] Add/remove user from role via CLI
URL: https://github.com/apache/airflow/pull/4572
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3752
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ X ] Here are some details about my PR, including screenshots of any UI changes:
   
       Update the `users` subcommand to enable 2 new actions:
   
       - `--add-role`: Make the user a member of the given role
       - `--remove-role`: Remove the user's membership in the given role
   
       For installations that use an external identity provider (e.g., Google
       OAuth) the username is typically a long ID string. For the sake of
       convenience, we allow the CLI operator to reference the target user
       via either their `username` or their `email` (but not both).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   I didn't see much scaffolding in place for testing the CLI. If someone can point me to an appropriate place to add a new test then I'll be happy to update the PR.
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ X ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ X ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services