You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by vaygr <gi...@git.apache.org> on 2017/02/15 18:20:18 UTC

[GitHub] libcloud pull request #988: Add ability to delete multi-value records in Rou...

GitHub user vaygr opened a pull request:

    https://github.com/apache/libcloud/pull/988

    Add ability to delete multi-value records in Route 53

    ## Ability to delete multi-value records in Route 53
    
    ### Description
    
    Currently any `.delete()` operation on multi-value records results in `RecordDoesNotExistError`. This PR handles record deletion correctly regardless of its type.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vaygr/libcloud route53-record-mv-delete

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #988
    
----
commit b2bb5dcbdcbaa3222619b92cabe061aa16d4bca1
Author: Vlad Glagolev <sc...@vaygr.net>
Date:   2017-02-15T18:16:20Z

    Add ability to delete multi-value records

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---