You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/03 14:47:57 UTC
[GitHub] [shardingsphere] xbkaishui opened a new pull request #6262: fix #4913 change image chinese to eng
xbkaishui opened a new pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262
Fixes #4913.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #6262: fix #4913 change image chinese to eng
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262#issuecomment-653705323
@xbkaishui We are glad to see your joining. :-)
Since the images could not show well on the GitHub page, I merged it.
Do you think it is better to rename `merge result` as `merged result`? For `merge` is a verb, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] xbkaishui commented on pull request #6262: fix #4913 change image chinese to eng
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262#issuecomment-653742067
that's better. forget me for my poor english :sweat_smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #6262: fix #4913 change image chinese to eng
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #6262: fix #4913 change image chinese to eng
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #6262:
URL: https://github.com/apache/shardingsphere/pull/6262#issuecomment-653705323
@xbkaishui We are glad to see your joining. :-)
Since the images could not show well on the GitHub page, I merged it.
Do you think it is better to rename `merge result` as `merged result`? For `merge` is a verb, right?
If so, maybe a new PR is welcomed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org