You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bomeng <gi...@git.apache.org> on 2016/05/16 23:47:46 UTC

[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

GitHub user bomeng opened a pull request:

    https://github.com/apache/spark/pull/13141

    [SPARK-14752] [SQL] fix kryo ordering serialization

    ## What changes were proposed in this pull request?
    
    When using Kryo as serializer and we will get `NullPointerException` exception for query with `ORDER BY'.
    
    ## How was this patch tested?
    
    I've added a new test cases to HashedRelationSuite.scala, since this issue is kind of related to Spark-14521.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bomeng/spark SPARK-14752

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13141
    
----
commit 66f0e6c352bae9e65eadada19b1cfead8b06b3aa
Author: bomeng <bm...@us.ibm.com>
Date:   2016-05-16T23:42:22Z

    fix kryo serialization

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13141#issuecomment-219594712
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58658/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/13141#issuecomment-219582225
  
    **[Test build #58658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58658/consoleFull)** for PR 13141 at commit [`66f0e6c`](https://github.com/apache/spark/commit/66f0e6c352bae9e65eadada19b1cfead8b06b3aa).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/13141#issuecomment-219594613
  
    **[Test build #58658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58658/consoleFull)** for PR 13141 at commit [`66f0e6c`](https://github.com/apache/spark/commit/66f0e6c352bae9e65eadada19b1cfead8b06b3aa).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #13141: [SPARK-14752] [SQL] fix kryo ordering serializati...

Posted by bomeng <gi...@git.apache.org>.
Github user bomeng closed the pull request at:

    https://github.com/apache/spark/pull/13141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13141#issuecomment-219594710
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org