You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-scm@portals.apache.org by at...@apache.org on 2010/05/27 22:44:11 UTC

svn commit: r948978 - in /portals/pluto: branches/pluto-2.0.x/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/ trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/

Author: ate
Date: Thu May 27 20:44:11 2010
New Revision: 948978

URL: http://svn.apache.org/viewvc?rev=948978&view=rev
Log:
Fix for PLUTO-581: org.apache.pluto.driver.url.impl.PortalURLParserImpl not properly decoding public/private render parameters
See: https://issues.apache.org/jira/browse/PLUTO-581
Thanks Mike Freedman for reporting!

Modified:
    portals/pluto/branches/pluto-2.0.x/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java
    portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java

Modified: portals/pluto/branches/pluto-2.0.x/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java
URL: http://svn.apache.org/viewvc/portals/pluto/branches/pluto-2.0.x/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java?rev=948978&r1=948977&r2=948978&view=diff
==============================================================================
--- portals/pluto/branches/pluto-2.0.x/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java (original)
+++ portals/pluto/branches/pluto-2.0.x/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java Thu May 27 20:44:11 2010
@@ -527,6 +527,13 @@ public class PortalURLParserImpl impleme
 
         // Split multiple values into a value array.
         String[] paramValues = value.split(VALUE_DELIM);
+        for (int i = 0; i < paramValues.length;i++){
+        	try {
+        		paramValues[i] = URLDecoder.decode(paramValues[i], "UTF-8");
+			} catch (UnsupportedEncodingException e) {
+				LOG.warn(e.getMessage(),e);
+			}
+        }
 
         // Construct portal URL parameter and return.
         return new PortalURLParameter(null, paramName, paramValues);

Modified: portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java?rev=948978&r1=948977&r2=948978&view=diff
==============================================================================
--- portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java (original)
+++ portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java Thu May 27 20:44:11 2010
@@ -527,6 +527,13 @@ public class PortalURLParserImpl impleme
 
         // Split multiple values into a value array.
         String[] paramValues = value.split(VALUE_DELIM);
+        for (int i = 0; i < paramValues.length;i++){
+        	try {
+        		paramValues[i] = URLDecoder.decode(paramValues[i], "UTF-8");
+			} catch (UnsupportedEncodingException e) {
+				LOG.warn(e.getMessage(),e);
+			}
+        }
 
         // Construct portal URL parameter and return.
         return new PortalURLParameter(null, paramName, paramValues);