[jira] [Resolved] (STORM-2804) TopoCache is not caching ACLs correctly

["Jungtaek Lim (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jungtaek Lim resolved STORM-2804.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Thanks [~ethanli], I merged into master.

> TopoCache is not caching ACLs correctly
> ---------------------------------------
>
>                 Key: STORM-2804
>                 URL: https://issues.apache.org/jira/browse/STORM-2804
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Ethan Li
>            Assignee: Ethan Li
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In the code [addTopology |https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/TopoCache.java#L123-L128]
> {code:java}
>  public void addTopology(final String topoId, final Subject who, final StormTopology topo)
>         throws AuthorizationException, KeyAlreadyExistsException, IOException {
>         final String key = ConfigUtils.masterStormCodeKey(topoId);
>         final List<AccessControl> acl = BlobStoreAclHandler.DEFAULT;
>         store.createBlob(key, Utils.serialize(topo), new SettableBlobMeta(acl), who);
>         topos.put(topoId, new WithAcl<>(acl, topo));
>     }
> {code}
> acl is being modified in store.createBlob(). But it's not populated to the topos.
> The same applies to the addTopoConf() function



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)