You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/21 02:13:05 UTC
[GitHub] [flink] vthinkxie opened a new pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
vthinkxie opened a new pull request #14440:
URL: https://github.com/apache/flink/pull/14440
## What is the purpose of the change
ref https://issues.apache.org/jira/browse/FLINK-20258
## Brief change log
Add explanation that "Effective Configuration" for JM/TM memory sizes include automatically derived values
## Verifying this change
- visit JM metric page
- visit TM metric page
- check the Effective Configuration column
before:
after:
<img width="1680" alt="截屏2020-12-21 上午10 11 42" src="https://user-images.githubusercontent.com/1506722/102732174-f1630d80-4374-11eb-998d-9ccaf90386c9.png">
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-748719031
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f48f79b5c577753b55f3c778d482ba089d4df5b0 (Mon Dec 21 02:15:57 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-748723664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f48f79b5c577753b55f3c778d482ba089d4df5b0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11088",
"triggerID" : "f48f79b5c577753b55f3c778d482ba089d4df5b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f48f79b5c577753b55f3c778d482ba089d4df5b0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11088)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-748723664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f48f79b5c577753b55f3c778d482ba089d4df5b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f48f79b5c577753b55f3c778d482ba089d4df5b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f48f79b5c577753b55f3c778d482ba089d4df5b0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-748719031
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9bd7db0cb8f3141fc4aa8ef779f43ef1b06856b2 (Fri May 28 06:57:05 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14440:
URL: https://github.com/apache/flink/pull/14440
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-748723664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f48f79b5c577753b55f3c778d482ba089d4df5b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11088",
"triggerID" : "f48f79b5c577753b55f3c778d482ba089d4df5b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f48f79b5c577753b55f3c778d482ba089d4df5b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11088)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-750117054
> I don't quite like the phrasing.
>
> * we should first list that these are the actual values used by Flink, then follow with the explanation
> * do not say "configured by the _user_"; the values may be set by the person submitting the job, the devops guy, some framework (e.g., AWS) or even Flink itself
> * do not mention flink-conf.yaml, because these options may be set on the command-line
> * "comes up with the missing values" sounds a bit...unsophisticated? Not sure how to describe it.
>
> I would suggest the following:
>
> ```
> This column shows the values that are actually used by Flink. These may differ from the configured values; Flink may adjust them to fit the actual setup, and automatically derives values that were not explicitly configured.
> ```
Sounds good 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp edited a comment on pull request #14440: [FLINK-20259][web] Add explanation to Effective Configuration in JM/TM
Posted by GitBox <gi...@apache.org>.
XComp edited a comment on pull request #14440:
URL: https://github.com/apache/flink/pull/14440#issuecomment-750117054
> I don't quite like the phrasing.
>
> * we should first list that these are the actual values used by Flink, then follow with the explanation
> * do not say "configured by the _user_"; the values may be set by the person submitting the job, the devops guy, some framework (e.g., AWS) or even Flink itself
> * do not mention flink-conf.yaml, because these options may be set on the command-line
> * "comes up with the missing values" sounds a bit...unsophisticated? Not sure how to describe it.
>
> I would suggest the following:
>
> ```
> This column shows the values that are actually used by Flink. These may differ from the configured values; Flink may adjust them to fit the actual setup, and automatically derives values that were not explicitly configured.
> ```
You have some good points. I like your proposal. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org