You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yongjinhou (via GitHub)" <gi...@apache.org> on 2024/06/07 06:55:54 UTC
[PR] [Bug](function) Fix function for cast string as int [doris]
yongjinhou opened a new pull request, #36039:
URL: https://github.com/apache/doris/pull/36039
## Proposed changes
Issue Number: close #36038
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow closed pull request #36039: [Bug](function) Fix function for cast string as int
URL: https://github.com/apache/doris/pull/36039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36039:
URL: https://github.com/apache/doris/pull/36039#issuecomment-2154254003
<details>
<summary>TPC-DS: <b>Total hot run time: 171697 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d2a4f9853716f139b704acb54a86780728862038, data reload: false
query1 915 383 376 376
query2 6475 2313 2430 2313
query3 6645 205 205 205
query4 19612 17394 17414 17394
query5 4154 452 468 452
query6 243 168 152 152
query7 4552 292 293 292
query8 304 288 296 288
query9 8414 2409 2348 2348
query10 435 279 273 273
query11 10726 10097 10145 10097
query12 138 88 85 85
query13 1615 347 362 347
query14 10102 6392 7396 6392
query15 236 180 174 174
query16 7711 285 263 263
query17 1350 510 501 501
query18 1921 270 273 270
query19 188 145 145 145
query20 96 81 83 81
query21 208 148 126 126
query22 4638 4247 4145 4145
query23 33446 32991 32962 32962
query24 11191 2728 2857 2728
query25 625 348 352 348
query26 1163 150 151 150
query27 2599 312 308 308
query28 7173 2059 2040 2040
query29 869 607 590 590
query30 269 152 149 149
query31 954 738 716 716
query32 88 55 51 51
query33 752 271 269 269
query34 973 476 466 466
query35 787 598 615 598
query36 1079 907 940 907
query37 159 68 71 68
query38 2882 2805 2771 2771
query39 866 783 806 783
query40 199 123 131 123
query41 54 53 55 53
query42 115 96 94 94
query43 583 547 524 524
query44 1236 752 739 739
query45 198 161 158 158
query46 1068 692 710 692
query47 1856 1807 1832 1807
query48 357 287 293 287
query49 990 396 413 396
query50 776 382 380 380
query51 6744 6666 6593 6593
query52 97 96 92 92
query53 358 278 282 278
query54 871 443 431 431
query55 71 71 72 71
query56 281 249 254 249
query57 1132 1074 1091 1074
query58 256 244 235 235
query59 3540 3032 3285 3032
query60 314 269 265 265
query61 89 89 89 89
query62 616 429 444 429
query63 311 285 283 283
query64 8951 2222 1809 1809
query65 3183 3077 3116 3077
query66 903 326 329 326
query67 15414 14813 14947 14813
query68 4562 533 537 533
query69 538 437 374 374
query70 1078 1144 1088 1088
query71 414 277 260 260
query72 6994 5459 5487 5459
query73 766 326 316 316
query74 5883 5603 5576 5576
query75 3391 2632 2675 2632
query76 2244 876 1010 876
query77 479 300 283 283
query78 10142 9884 9848 9848
query79 2253 507 511 507
query80 1148 472 445 445
query81 597 218 224 218
query82 1039 100 99 99
query83 240 166 171 166
query84 256 85 84 84
query85 1330 346 263 263
query86 440 336 303 303
query87 3266 3100 3138 3100
query88 3396 2306 2312 2306
query89 472 377 373 373
query90 1800 185 181 181
query91 121 99 95 95
query92 71 47 48 47
query93 1822 515 497 497
query94 1288 182 179 179
query95 399 307 302 302
query96 586 259 253 253
query97 3197 2969 3018 2969
query98 219 198 200 198
query99 1333 845 857 845
Total cold run time: 268880 ms
Total hot run time: 171697 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #36039:
URL: https://github.com/apache/doris/pull/36039#issuecomment-2154221101
should not change this behavior. becaues be return null when do cast('123.123' as int). we should let fe return same result with be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36039:
URL: https://github.com/apache/doris/pull/36039#issuecomment-2154262199
<details>
<summary>ClickBench: <b>Total hot run time: 30.29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d2a4f9853716f139b704acb54a86780728862038, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.22 0.05 0.04
query4 1.67 0.06 0.06
query5 0.49 0.51 0.49
query6 1.13 0.72 0.73
query7 0.01 0.01 0.01
query8 0.05 0.04 0.04
query9 0.54 0.50 0.49
query10 0.55 0.55 0.54
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.59 0.59 0.61
query14 0.75 0.78 0.77
query15 0.83 0.81 0.81
query16 0.36 0.37 0.37
query17 0.96 0.97 0.94
query18 0.22 0.22 0.27
query19 1.82 1.79 1.75
query20 0.02 0.01 0.01
query21 15.52 0.69 0.66
query22 4.68 6.76 1.88
query23 18.32 1.37 1.21
query24 2.11 0.21 0.22
query25 0.15 0.08 0.09
query26 0.27 0.17 0.17
query27 0.08 0.08 0.08
query28 13.21 1.03 1.00
query29 13.06 3.31 3.21
query30 0.24 0.05 0.06
query31 2.88 0.38 0.39
query32 3.28 0.47 0.47
query33 2.84 2.90 2.92
query34 17.20 4.37 4.38
query35 4.43 4.45 4.49
query36 0.71 0.49 0.46
query37 0.18 0.15 0.15
query38 0.15 0.14 0.15
query39 0.05 0.03 0.04
query40 0.17 0.13 0.14
query41 0.09 0.04 0.04
query42 0.05 0.04 0.05
query43 0.05 0.04 0.04
Total cold run time: 110.34 s
Total hot run time: 30.29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36039:
URL: https://github.com/apache/doris/pull/36039#issuecomment-2154238473
<details>
<summary>TPC-H: <b>Total hot run time: 40714 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d2a4f9853716f139b704acb54a86780728862038, data reload: false
------ Round 1 ----------------------------------
q1 17633 4329 4230 4230
q2 2027 206 190 190
q3 10416 1218 1078 1078
q4 10195 766 807 766
q5 7491 2710 2700 2700
q6 224 141 133 133
q7 965 607 609 607
q8 9233 2096 2078 2078
q9 9107 6633 6646 6633
q10 9126 3881 3890 3881
q11 506 238 241 238
q12 488 229 230 229
q13 17219 3238 3178 3178
q14 267 233 235 233
q15 527 476 473 473
q16 495 392 387 387
q17 991 657 746 657
q18 8297 7866 7752 7752
q19 9898 1341 1354 1341
q20 672 315 305 305
q21 5151 3284 4062 3284
q22 406 345 341 341
Total cold run time: 121334 ms
Total hot run time: 40714 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4686 4403 4436 4403
q2 372 276 282 276
q3 3139 2899 2893 2893
q4 2005 1675 1711 1675
q5 5378 5342 5490 5342
q6 221 125 127 125
q7 2180 1855 1801 1801
q8 3243 3390 3382 3382
q9 8614 8608 8528 8528
q10 3992 3862 3829 3829
q11 601 494 484 484
q12 798 660 628 628
q13 16956 2971 3115 2971
q14 298 266 289 266
q15 533 491 482 482
q16 488 434 418 418
q17 1804 1510 1448 1448
q18 7936 7800 7307 7307
q19 2996 1677 1552 1552
q20 4066 1795 1757 1757
q21 6468 4707 4819 4707
q22 687 550 526 526
Total cold run time: 77461 ms
Total hot run time: 54800 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #36039:
URL: https://github.com/apache/doris/pull/36039#issuecomment-2154282117
> should not change this behavior. becaues be return null when do cast('123.123' as int). we should let fe return same result with be
那不是应该修改下be的对应函数吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36039:
URL: https://github.com/apache/doris/pull/36039#issuecomment-2154210406
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](function) Fix function for cast string as int [doris]
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #36039:
URL: https://github.com/apache/doris/pull/36039#issuecomment-2154211937
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org