You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/05/30 17:11:37 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #35813: MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value

pitrou commented on code in PR #35813:
URL: https://github.com/apache/arrow/pull/35813#discussion_r1210576875


##########
python/pyarrow/compute.py:
##########
@@ -483,10 +483,16 @@ def take(data, indices, *, boundscheck=True, memory_pool=None):
 
 
 def fill_null(values, fill_value):
-    """
-    Replace each null element in values with fill_value. The fill_value must be
-    the same type as values or able to be implicitly casted to the array's
-    type.
+    """Replace each null element in values with a corresponding
+    element from fill_value.
+
+    If fill_value is scalar-like, then every null element in values
+    will be replaced with fill_value. If fill_value is array-like,
+    then the i-th element in values will be replaced witth the i-th

Review Comment:
   ```suggestion
       then the i-th element in values will be replaced with the i-th
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org