You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/06 13:32:41 UTC

[GitHub] [pulsar] nicoloboschi opened a new pull request, #17951: [improve][connector] JDBC sink: allow any jdbc driver

nicoloboschi opened a new pull request, #17951:
URL: https://github.com/apache/pulsar/pull/17951

   ### Motivation
   
   At the moment in the JDBC core module there's a mapping between JDBC url and the driver class name. This limits the possibility to take the JDBC core and put a different JDBC driver. Also the class name driver initialization is not helpful at all since the first time the JDBC api will try to find a driver is just in the next line while creating a new connection. 
   
   ### Modifications
   
   * Removed the mapping and the class eager initialization. If the JDBC Api is not able to find a driver for the given url, an exception will be raised anyway.
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #17951: [improve][connector] JDBC sink: allow any jdbc driver

Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #17951:
URL: https://github.com/apache/pulsar/pull/17951


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #17951: [improve][connector] JDBC sink: allow any jdbc driver

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17951:
URL: https://github.com/apache/pulsar/pull/17951#issuecomment-1272797037

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org