You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/04 21:11:39 UTC
[GitHub] codecov-io commented on issue #6027: Sorting tables by "modified"
is broken
codecov-io commented on issue #6027: Sorting tables by "modified" is broken
URL: https://github.com/apache/incubator-superset/pull/6027#issuecomment-427170761
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6027?src=pr&el=h1) Report
> Merging [#6027](https://codecov.io/gh/apache/incubator-superset/pull/6027?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f9344f13df19effc744db7c31d29413918923f72?src=pr&el=desc) will **increase** coverage by `1.16%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6027?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6027 +/- ##
==========================================
+ Coverage 64.6% 65.77% +1.16%
==========================================
Files 446 446
Lines 23814 25109 +1295
Branches 2639 2639
==========================================
+ Hits 15386 16515 +1129
- Misses 8415 8581 +166
Partials 13 13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6027?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/6027/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `85.97% <100%> (ø)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6027/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `81.13% <0%> (+0.75%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6027/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `55.7% <0%> (+0.87%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6027/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `82.28% <0%> (+1.24%)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/6027/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `73.93% <0%> (+2.5%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6027/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `78.52% <0%> (+4.4%)` | :arrow_up: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/6027/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `57.26% <0%> (+7.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6027?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6027?src=pr&el=footer). Last update [f9344f1...5b26313](https://codecov.io/gh/apache/incubator-superset/pull/6027?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org