[GitHub] [apisix] moonming commented on a change in pull request #2164: fix:log-rotate.t is unstable

[GitBox <gi...@apache.org>]

moonming commented on a change in pull request #2164:
URL: https://github.com/apache/apisix/pull/2164#discussion_r483897033



##########
File path: t/plugin/log-rotate.t
##########
@@ -51,17 +51,30 @@ __DATA__
         content_by_lua_block {
             ngx.log(ngx.ERR, "start xxxxxx")

Review comment:
       The log here should be more meaningful, instead of writing a random

##########
File path: t/plugin/log-rotate.t
##########
@@ -51,17 +51,30 @@ __DATA__
         content_by_lua_block {
             ngx.log(ngx.ERR, "start xxxxxx")
             ngx.sleep(2.5)
-
+            local has_split_access_file = false
+            local has_split_error_file = false
             local lfs = require("lfs")
-            for file in lfs.dir(ngx.config.prefix() .. "/logs/") do
-                ngx.say(file)
+            for fileName in lfs.dir(ngx.config.prefix() .. "/logs/") do

Review comment:
       `fileName` to `file_name`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org