[GitHub] flink pull request #6252: [FLINK-9742][Table API & SQL] Expose Expression.re...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6252#discussion_r200345063
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionUtils.scala ---
    @@ -22,13 +22,16 @@ import java.lang.{Boolean => JBoolean, Byte => JByte, Double => JDouble, Float =
     import java.math.{BigDecimal => JBigDecimal}
     import java.sql.{Date, Time, Timestamp}
     
    -import org.apache.flink.api.common.typeinfo.BasicTypeInfo
    +import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation}
     import org.apache.flink.streaming.api.windowing.time.{Time => FlinkTime}
     import org.apache.flink.table.api.ValidationException
     import org.apache.flink.table.calcite.FlinkTypeFactory
     import org.apache.flink.table.typeutils.{RowIntervalTypeInfo, TimeIntervalTypeInfo}
     
     object ExpressionUtils {
    +  def getReturnType(expr: Expression): TypeInformation[_] = {
    --- End diff --
    
    Please add Scala docs since this is a public method.
    
    Rename to `getResultType` for consistency?
    



---