You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Andreas Lehmkühler (JIRA)" <ji...@apache.org> on 2009/06/15 11:15:07 UTC

[jira] Created: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

rendering issues during clipping (W/W*-operator)
------------------------------------------------

                 Key: PDFBOX-483
                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
             Project: PDFBox
          Issue Type: Bug
          Components: PDFReader
    Affects Versions: 0.8.0-incubator
            Reporter: Andreas Lehmkühler


As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).

E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.



[1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Steve Poling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Poling updated PDFBOX-483:
--------------------------------

    Attachment:     (was: filled.pdf)

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>         Attachments: filled.pdf-1.png
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Daniel Wilson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Wilson updated PDFBOX-483:
---------------------------------

    Attachment: filled.pdf-1.png

Here's the output from Steve's file, as rendered on my system following Andreas' update.

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>         Attachments: filled.pdf, filled.pdf-1.png
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Andreas Lehmkühler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Lehmkühler resolved PDFBOX-483.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8.0-incubator

With version 791272 I've fixed the issue with the clipping operators.

The documents from PDFBOX-358 and PDFBOX-478 are rendering like before. I guess there are a lot of other documents which will render better than before, e.g. the Testformular.pdf from PDFBOX-142. And of course daniels docs are still rendering fine.

The were several problems to solve

- The clippingpath is part of the graphicstate. Consequently we have to save/restore the path whenever pdfbox processes the q/Q-operators.
- A new clippingpath has to be intersected with the old one if present
- we have to set the clipping path before every drawing-operation to the graphics2d

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Andreas Lehmkühler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727946#action_12727946 ] 

Andreas Lehmkühler commented on PDFBOX-483:
-------------------------------------------

My changes are only related to clipping stuff, there were no changes to color management or something like that. The main changes canl be found in PageDrawer and PDGraphicsState. Most of the other changes were made to reestablish checkstyle compliance (tabs, methodnames starting with uppercase letters etc.)

@Daniel
I have some questions about your testfiles. 

They are looking different using different readers. 

HotRodCMYK: the shadow of the text has different colors
- Acrobat Reader 9.x: dark gray
- PDFBox PDFReader: white
- KPDF on my linux box: black

ArchiveRGB: the border of the big "1865"
- Acrobat Reader 9.x: no visible border
- PDFBox PDFReader: white border

How should they look alike?

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>         Attachments: filled.pdf-1.png
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Daniel Wilson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727742#action_12727742 ] 

Daniel Wilson commented on PDFBOX-483:
--------------------------------------

Congratulations, Andreas!  This one was not easy!

I have updated several of the test cases with the output from this version. Flyer2 looks a lot better and several others list changes that I can't see ... so I'm updating to the output from the new code.

My test files, however, are not all looking right.

HotRodCMYK, for example ... the new output is much darker in the letters ... the clipped part where the bitmask is. Likewise ArchiveRGB.  The latter shows clearly a diagonal streaking of the pattern, something that HotRodCMYK hints at but does not show clearly.

There are some others I have that show the same thing that I've not received approval to release.  But those 2 I've released do show the problem.

Given the chance, I'll dig into this, being mindful of the other test cases -- like Flyer2.  But if something comes to your mind on it, I'd appreciate the suggestions!

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>         Attachments: filled.pdf
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Daniel Wilson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722573#action_12722573 ] 

Daniel Wilson commented on PDFBOX-483:
--------------------------------------

sounds like a good half-way measure,

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Steve Poling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Poling updated PDFBOX-483:
--------------------------------

    Attachment: filled.pdf

The text in this document does not appear. Using the current svn trunk (7/6/09), only the lines render and a small ellipse segment at the lower left corner. If I disable the W/W* lines from PageDrawer.properties, the missing text renders in the wrong typeface. You'll note that embedded fonts are employed.

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>         Attachments: filled.pdf
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Andreas Lehmkühler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722535#action_12722535 ] 

Andreas Lehmkühler commented on PDFBOX-483:
-------------------------------------------

After performing some tests it seems that the issue occurs if clipping is used in combination with marked content.  Chapter 10.5.2 "Marked Content and Clipping" of the pdf-reference 1.7 confirms this assumption. Obviously in some cases clipping isn't considered to be part of the painting.

I'm afraid it'll not that easy to implement the rules from the reference, but perhaps in the first step it'll be sufficient to just disable clipping within marked content. I'll do some tests and we'll see.

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Andreas Lehmkühler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727360#action_12727360 ] 

Andreas Lehmkühler commented on PDFBOX-483:
-------------------------------------------

I've forgot to mention that the issue has nothing to do with my first guess. I can't find a sideeffect based on marked content.

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-483) rendering issues during clipping (W/W*-operator)

Posted by "Daniel Wilson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727762#action_12727762 ] 

Daniel Wilson commented on PDFBOX-483:
--------------------------------------

Steve, 

Yours appears to me to be rendering right ...  I'll attach the PNG my testing generated.

> rendering issues during clipping (W/W*-operator)
> ------------------------------------------------
>
>                 Key: PDFBOX-483
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-483
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDFReader
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andreas Lehmkühler
>             Fix For: 0.8.0-incubator
>
>         Attachments: filled.pdf, filled.pdf-1.png
>
>
> As I already stated in this thread [1], there are some rendering issues after adding support for the W/W*-operators (clipping).
> E.g. the rendering of Flyer2.pdf from PDFBOX-358 and the doc attached to PDFBOX-478 is getting worse if clipping is activated.
> [1] http://markmail.org/message/vt5ghmqxbt2hj2ku

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.