You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ritikam2 (via GitHub)" <gi...@apache.org> on 2023/03/16 19:26:46 UTC
[GitHub] [spark] ritikam2 commented on a diff in pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect
ritikam2 commented on code in PR #40116:
URL: https://github.com/apache/spark/pull/40116#discussion_r1139265664
##########
sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala:
##########
@@ -40,12 +40,15 @@ abstract class SQLImplicits extends LowPrioritySQLImplicits {
*/
implicit class StringToColumn(val sc: StringContext) {
def $(args: Any*): ColumnName = {
- new ColumnName(sc.s(args: _*))
+ if (sc.parts.length == 1 && sc.parts.contains("*")) {
Review Comment:
Yuo this is redundant. Removed it in the latest build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org